Fix swaps when initial network not Mainnet#9745
Merged
Conversation
This is a continuation of #9726, which did not fix the problem described. If the initial network when the extension is started is something other than Mainnet, the swaps controller will never successfully retrieve swap quotes. This is because `ethers` will continue to communicate with whichever network the provider was initially on. We tried fixing this by hard-coding the `chainId` to Mainnet's `chainId` when constructing the Ethers provider, but this did not work. I suspect this failed because the `provider` we pass to `ethers` is not compliant with EIP 1193, as `ethers` doubtless expects it to be. Instead the entire `ethers` provider is now reconstructed each time the network changes. This mirrors the approach we take in some other controllers.
tmashuang
reviewed
Oct 28, 2020
Co-authored-by: Thomas Huang <tmashuang@users.noreply.github.com>
tmashuang
approved these changes
Oct 28, 2020
Contributor
tmashuang
left a comment
There was a problem hiding this comment.
Repro'd and LGTM. In my reproduction there is a slight delay of loading the my tokens in Swap from when immediately going to swap after network change, but don't know how we would optimize this.
Collaborator
Builds ready [e47924d]
Page Load Metrics (494 ± 71 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #9726, which did not fix the problem described.
If the initial network when the extension is started is something other than Mainnet, the swaps controller will never successfully retrieve swap quotes. This is because
etherswill continue to communicate with whichever network the provider was initially on.We tried fixing this by hard-coding the
chainIdto Mainnet'schainIdwhen constructing the Ethers provider, but this did not work. I suspect this failed because theproviderwe pass toethersis not compliant with EIP 1193, asethersdoubtless expects it to be.Instead the entire
ethersprovider is now reconstructed each time the network changes. This mirrors the approach we take in some other controllers.Manual testing steps: