Check if swapTokenValue is negative and set prefix accordingly#9743
Merged
Check if swapTokenValue is negative and set prefix accordingly#9743
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Oct 28, 2020
Gudahtt
reviewed
Oct 28, 2020
Comment on lines
+148
to
+154
| if (isNegative) { | ||
| prefix = '' | ||
| } else if (isViewingReceivedTokenFromSwap && !isNegative) { | ||
| prefix = '+' | ||
| } else { | ||
| prefix = '-' | ||
| } |
Member
There was a problem hiding this comment.
I wrote out the four different branches to help myself think through it:
Suggested change
| if (isNegative) { | |
| prefix = '' | |
| } else if (isViewingReceivedTokenFromSwap && !isNegative) { | |
| prefix = '+' | |
| } else { | |
| prefix = '-' | |
| } | |
| if (isViewingReceivedTokenFromSwap) { | |
| if (isNegative) { | |
| // do nothing - the minus should already be there | |
| } else { | |
| prefix = '+' | |
| } | |
| } else { | |
| if (isNegative) { | |
| // this case should be impossible - how can you send _negative_ tokens? | |
| } else { | |
| // a positive value should be shown as a loss, as this is the amount of tokens sent. | |
| prefix = '-' | |
| } | |
| } |
The only one you're missing is where a negative amount of tokens was sent, and I can't imagine how that would be possible. So I think your logic here is sound.
Gudahtt
previously approved these changes
Oct 28, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Just one minor suggestion to simplify that one conditional.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Collaborator
Builds ready [5ed6711]
Page Load Metrics (433 ± 58 ms)
|
Gudahtt
approved these changes
Oct 28, 2020
Collaborator
Builds ready [c66dd0f]
Page Load Metrics (415 ± 55 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9739, alternative PR that addresses how to present negative values.
Before
After