Merged
Conversation
rekmarks
commented
Oct 28, 2020
Comment on lines
206
to
210
Member
Author
There was a problem hiding this comment.
This spares us from re-pushing NETWORKS_ROUTE unnecessarily. Used in NetworkForm.componentWillUnmount.
rekmarks
commented
Oct 29, 2020
Comment on lines
38
to
39
Member
Author
There was a problem hiding this comment.
The default state is '', and resetting it on unmount works equally well.
b668e20 to
59a38a2
Compare
Collaborator
Builds ready [59a38a2]
Page Load Metrics (560 ± 80 ms)
|
Collaborator
Builds ready [ab80832]
Page Load Metrics (518 ± 86 ms)
|
Contributor
|
Works like a charm on my machine. 👍 |
rachelcope
approved these changes
Oct 29, 2020
rachelcope
left a comment
There was a problem hiding this comment.
This looks great. Great improvements to make it consistent with the rest of the settings pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our network settings page has been janky for a long time. This PR attempts to update its UI such that it's inline with our other settings pages. This was accomplished by the creation of an additional route used only in the popup, for the network form.
My sense is that the CSS of this page is still probably less than great, but it ought to do for now. Reviewers should pay extra attention to my use of routes and
history, since I'm inexperienced withreact-router-dom.These changes mostly affect the popup view; the fullscreen view should be largely unaffected.
Changes in Detail
viewOnlyTesting Steps
Screenshots / Recordings
Before
After
After (Recording)
Note: The weird shadows that stick around are just an artifact of the recording.