Skip to content

Remove redundant mocha command#9738

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-redundant-mocha-command
Oct 28, 2020
Merged

Remove redundant mocha command#9738
Gudahtt merged 1 commit intodevelopfrom
remove-redundant-mocha-command

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Oct 27, 2020

The command mocha was included twice in test:unit:global accidentally. The second occurrence was interpreted as a filename, and would result in the following warning:

Warning: Cannot find any files matching pattern "mocha"

The second instance has been removed, and the warning no longer appears.

The command `mocha` was included twice in `test:unit:global`
accidentally. The second occurrence was interpreted as a filename, and
would result in the following warning:

`Warning: Cannot find any files matching pattern "mocha"`

The second instance has been removed, and the warning no longer
appears.
@Gudahtt Gudahtt requested a review from a team as a code owner October 27, 2020 20:59
@Gudahtt Gudahtt requested a review from kumavis October 27, 2020 20:59
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [23fef60]
Page Load Metrics (427 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint319148199
domContentLoaded31267242611555
load31467442711555
domInteractive31267242511555

@Gudahtt Gudahtt merged commit d0d7a3d into develop Oct 28, 2020
@Gudahtt Gudahtt deleted the remove-redundant-mocha-command branch October 28, 2020 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants