Revert "Update main-quote-summary designs/styles (#9612)"#9722
Merged
Gudahtt merged 1 commit intoVersion-v8.1.3from Oct 27, 2020
Merged
Revert "Update main-quote-summary designs/styles (#9612)"#9722Gudahtt merged 1 commit intoVersion-v8.1.3from
Gudahtt merged 1 commit intoVersion-v8.1.3from
Conversation
This reverts commit 5456d55.
Collaborator
Builds ready [ee539b4]
Page Load Metrics (390 ± 50 ms)
|
0ecf7f1 to
e1896de
Compare
e1896de to
aff164b
Compare
danjm
approved these changes
Oct 27, 2020
Contributor
danjm
left a comment
There was a problem hiding this comment.
LGTM. Checked the code diff against the PR being reverted and QA'd in the browser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5456d55 (#9612)
Explanation:
This is being temporarily reverted because it has obscured whether the current quote is the best quote. This is a partial implementation of a design that moved the "Best Quote" label to the bottom section of the screen, which was outside the scope of this PR.
Manual testing steps: