Prevent React warning for custom slippage#9706
Merged
darkwing merged 2 commits intoMetaMask:developfrom Oct 28, 2020
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
brad-decker
previously approved these changes
Oct 23, 2020
Gudahtt
previously approved these changes
Oct 23, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Curious - we initialize customValue to an emptry string, but then we set the customValue to both undefined and null in different places 🤦
This approach to preventing this warning seems good to me! But we should probably align on one standard way of setting an empty value in this component.
Gudahtt
approved these changes
Oct 28, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Thanks for cleaning up the other "empty" custom value cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
Fixes an issue I somehow triggered by clicking in the custom slippage box quickly:
Manual testing steps: