Provide image sizing so there's no jump when opening the swaps token search#9700
Merged
darkwing merged 1 commit intoMetaMask:developfrom Oct 23, 2020
Merged
Provide image sizing so there's no jump when opening the swaps token search#9700darkwing merged 1 commit intoMetaMask:developfrom
darkwing merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
brad-decker
approved these changes
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
As of right now, the first time you open the swaps "Swap from" dropdown, there's quick/weird jump in the cursor because the search icon hasn't loaded yet. By providing width and height attributes, that jump no longer happens. Very small UX improvement but less UI micro-jumps is good.
Manual testing steps: