Use local ETH_SWAPS_TOKEN_OBJECT in swaps token array#9678
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…oken', in the swaps token array
cebf223 to
0075612
Compare
Collaborator
Builds ready [0075612]
Page Load Metrics (438 ± 61 ms)
|
brad-decker
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swaps '/tokens' api returns a list of token objects. These object always have the following properties:
symbol,decimals,address. They sometimes have aniconUrl. The list include an object for the "ETH" token, that only includes symbol, decimals and address.We have a local constant
ETH_SWAPS_TOKEN_OBJECTthat includes a local iconUrl for the "ETH" token. This PR causes us to explicitly replace the ETH token object returned by the api with our local one. This will ensure the iconUrl is always available on the eth token object.