Fix ENS resolution of .eth URLs with query strings#9674
Merged
Conversation
Our ENS resolver for the browser address bar was incorrectly resolving addresses that included query strings. We were concatenating the `path` property with the `search` property, despite the fact that the `path` property already contains `search`. As a result, `search` was duplicated in the resolved addresses. For example, if an IPFS content ID was found for this address, the resolved address for `metamask.eth/?foo=bar` would have the path `/?foo=bar?foo=bar` The original intent was likely to use `pathname` in place of `path`. The resolver has been updated to use `pathname`, and the query string now appears only once in the resolved address.
Member
Author
DevTools screenshots:Before:
After:
|
Collaborator
Builds ready [445cf60]
Page Load Metrics (503 ± 62 ms)
|
whymarrh
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our ENS resolver for the browser address bar was incorrectly resolving addresses that included query strings. We were concatenating the
pathproperty with thesearchproperty, despite the fact that thepathproperty already containssearch. As a result,searchwas duplicated in the resolved addresses.For example, if an IPFS content ID was found for this address, the resolved address for
metamask.eth/?foo=barwould have the path/?foo=bar?foo=barThe original intent was likely to use
pathnamein place ofpath. The resolver has been updated to usepathname, and the query string now appears only once in the resolved address.