Fix sorting Quote Source column of quote sort list#9658
Merged
Conversation
Collaborator
Builds ready [62103e6]
Page Load Metrics (754 ± 133 ms)
|
danjm
previously approved these changes
Oct 20, 2020
Contributor
danjm
left a comment
There was a problem hiding this comment.
I'm unsure what the difference between liquiditySource and quoteSource
There is no difference. At some point the property was renamed in quotesToRenderableData() and the correct updates were not made in other locations.
This fix is correct.
Sorting was broken for the "Quote Source" column of the quote sort list. Attempting to sort by this column would arrange the quotes in a seemingly random order. It appears that this was due to this column being programmed to sort by a property called `liquiditySource`, which does not exist in the quote data. I'm unsure what the difference between `liquiditySource` and `quoteSource` was supposed to be; the values in the mocks are all identical. All references to `liquiditySource` have been updated to refer to `quoteSource` instead, and the sorting now works correctly.
62103e6 to
fcc98af
Compare
Member
Author
|
I just had to update this to resolve conflicts; the diff should still be the same as it was before. |
Collaborator
Builds ready [fcc98af]
Page Load Metrics (465 ± 62 ms)
|
brad-decker
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting was broken for the "Quote Source" column of the quote sort list. Attempting to sort by this column would arrange the quotes in a seemingly random order.
It appears that this was due to this column being programmed to sort by a property called
liquiditySource, which does not exist in the quote data. I'm unsure what the difference betweenliquiditySourceandquoteSourcewas supposed to be; the values in the mocks are all identical.All references to
liquiditySourcehave been updated to refer toquoteSourceinstead, and the sorting now works correctly.