Skip to content

Remove non-existent metaMaskFee property#9657

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-non-existent-prop
Oct 20, 2020
Merged

Remove non-existent metaMaskFee property#9657
Gudahtt merged 1 commit intodevelopfrom
remove-non-existent-prop

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Oct 20, 2020

The metaMaskFee property on the "quote data" PropType was not used, and it never existed in practice. This resulted in PropType errors.

The non-existent property has been removed.

The `metaMaskFee` property on the "quote data" PropType was not used,
and it never existed in practice. This resulted in PropType errors.

The non-existent property has been removed.
@Gudahtt Gudahtt requested a review from a team as a code owner October 20, 2020 04:47
@Gudahtt Gudahtt requested a review from kumavis October 20, 2020 04:47
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d51a760]
Page Load Metrics (1161 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded64915181156256123
load66115191161255122
domInteractive64815171155256123

@Gudahtt Gudahtt merged commit 97450cd into develop Oct 20, 2020
@Gudahtt Gudahtt deleted the remove-non-existent-prop branch October 20, 2020 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants