Fix React warning about missing key in AwaitingSwap#9655
Merged
Conversation
The `AwaitingSwap` component was emitting a React warning when rendered because a component was being rendered in an array without having a `key` prop set. A key has been added to the `CountdownTimer` component, which is passed into the translation helper in an array. The warning no longer appears.
Collaborator
Builds ready [3e49e7a]
Page Load Metrics (1053 ± 117 ms)
|
danjm
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AwaitingSwapcomponent was emitting a React warning when rendered because a component was being rendered in an array without having akeyprop set.A key has been added to the
CountdownTimercomponent, which is passed into the translation helper in an array. The warning no longer appears.