Use undefined as default prop for onClick#9654
Merged
rickycodes merged 1 commit intodevelopfrom Oct 21, 2020
Merged
Conversation
Collaborator
Builds ready [bdaea3c]
Page Load Metrics (441 ± 54 ms)
|
Member
|
It looks like this needs to be rebased. The dependency audit failure was fixed a while back. From the look of the commit history, you may have accidentally based this off of |
bdaea3c to
3b0908e
Compare
Collaborator
Builds ready [3b0908e]
Page Load Metrics (421 ± 56 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was taking a look at how this is handled in the extension, it seems this is the one instance where we're using
nullvsundefinedwhich we use here: https://github.com/MetaMask/metamask-extension/blob/develop/ui/app/components/ui/menu/menu-item.js#L32 here: https://github.com/MetaMask/metamask-extension/blob/develop/ui/app/components/ui/metafox-logo/metafox-logo.component.js#L12 and a few other spotsthought we might as well make it consistent