Fix contentText PropType of InfoTooltip#9652
Merged
Conversation
The `InfoTooltip` component had a `contentText` prop with a PropType of `string` that was being passed a `node` as of #9614. This resulted in a PropType error. The `contentText` prop was being passed directly to `Tooltip` component as the prop `html`, which has a PropType of `node`. A string is a valid `node` type, which is why this worked before. The `contentText` prop is now of type `node`, and the error no longer appears.
Collaborator
Builds ready [f29d07d]
Page Load Metrics (373 ± 39 ms)
|
danjm
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InfoTooltipcomponent had acontentTextprop with a PropType ofstringthat was being passed anodeas of #9614. This resulted in a PropType error.The
contentTextprop was being passed directly toTooltipcomponent as the prophtml, which has a PropType ofnode. A string is a validnodetype, which is why this worked before.The
contentTextprop is now of typenode, and the error no longer appears.