Merged
Conversation
Collaborator
Builds ready [1ba56f7]
Page Load Metrics (418 ± 62 ms)
|
Gudahtt
approved these changes
Oct 19, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
This is an improvement, but the problem persists when the fiat value is large.
We need to come back to this and fix it properly using CSS, with dynamic column sizes and ellipses for long values. Looks good for now though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Estimated network feeline in the Fee Card of the View Quote component would sometimes split. This PR ensures it will never split by decreasing the network fee decimals from 6 to 5, and setting the same padding (12px) for the bold row as the non-bold row.The alignment of the two rows is not great, but it looks even worse if the row splits.
Before:
Appearance: