Skip to content

Savings and costs analytics data#9622

Merged
danjm merged 1 commit intodevelopfrom
savings-and-costs-analytics-data
Oct 20, 2020
Merged

Savings and costs analytics data#9622
danjm merged 1 commit intodevelopfrom
savings-and-costs-analytics-data

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Oct 16, 2020

After this PR, we will be collecting data on savings as calculated in #9611 in our segment/mixpanel analytics.

@danjm danjm requested a review from a team as a code owner October 16, 2020 15:00
@danjm danjm requested a review from danfinlay October 16, 2020 15:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm force-pushed the savings-and-costs-analytics-data branch from bdf1cff to 3143e4a Compare October 16, 2020 15:10
@danjm danjm changed the base branch from develop to swaps-average-costs-calculation October 16, 2020 15:13
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 16, 2020

Builds ready [3143e4a]
Page Load Metrics (390 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29423642
domContentLoaded29358838910048
load29458939010048
domInteractive29358838910048

brad-decker
brad-decker previously approved these changes Oct 16, 2020
View reviewed changes
@rekmarks rekmarks force-pushed the swaps-average-costs-calculation branch 2 times, most recently from bb610df to fa3f6c6 Compare October 18, 2020 19:39
@danjm danjm force-pushed the savings-and-costs-analytics-data branch from 3143e4a to 4f9a1a6 Compare October 19, 2020 08:22
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 19, 2020

Builds ready [4f9a1a6]
Page Load Metrics (1081 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded65515261074263126
load66015291081265127
domInteractive65515261074263126

Base automatically changed from swaps-average-costs-calculation to develop October 19, 2020 21:52
@rekmarks rekmarks dismissed brad-decker’s stale review October 19, 2020 21:52

The base branch was changed.

@danjm danjm force-pushed the savings-and-costs-analytics-data branch from 4f9a1a6 to 6cfec66 Compare October 20, 2020 13:22
@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented Oct 20, 2020

This has been rebased. The code has not changed since @brad-decker's previous review

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 20, 2020

Builds ready [6cfec66]
Page Load Metrics (376 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28423442
domContentLoaded2985733756531
load3005753766531
domInteractive2985733746531

@danjm danjm merged commit 2c9a082 into develop Oct 20, 2020
@danjm danjm deleted the savings-and-costs-analytics-data branch October 20, 2020 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danfinlay danfinlay Awaiting requested review from danfinlay

1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-swaps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danjm @metamaskbot @brad-decker