Remove transactionCategory in favor of expanding type to cover it's need#9545
Closed
brad-decker wants to merge 4 commits intodevelopfrom
Closed
Remove transactionCategory in favor of expanding type to cover it's need#9545brad-decker wants to merge 4 commits intodevelopfrom
brad-decker wants to merge 4 commits intodevelopfrom
Conversation
brad-decker
commented
Oct 9, 2020
Comment on lines
714
to
715
Contributor
Author
There was a problem hiding this comment.
this can be removed/simplified now that I have the typedefs.
a7cd47f to
ede2cee
Compare
Collaborator
Builds ready [ede2cee]
Page Load Metrics (455 ± 58 ms)
|
69787a0 to
a7dcf7f
Compare
a7dcf7f to
1931c06
Compare
ede2cee to
f505c6e
Compare
f505c6e to
c690f8d
Compare
Collaborator
Builds ready [c690f8d]
Page Load Metrics (415 ± 52 ms)
|
67d5208 to
24a5ee3
Compare
1e7048b to
018b35b
Compare
Contributor
Author
|
superseded by #10615 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There were previously only three "types" of transaction:
standardcancelretryA fourth unintended case for
typewasundefinedwhich was the case forincomingtransactionsstandard essentially means "not cancel or retry" and in any case where we look at standard what we actually care about is
transactionCategory.This pull request removes
transactionCategoryin favor of adding all of the 'categories' as additionaltypes.This should significantly cut down on some confusing thought cycles while having no impact on the extension. I might be missing some cases, though. Let me know what you think!
Details of Implementation
_determineTransactionCategory->_determineTransactionTypetransactionCategory: 'incoming'->type: 'incoming'transactionCategory->typefor all code touching the categoryTransactionMetatypedef to the transactions constant and use new typedefs in itPrior work
this depends on #9459 and is based on it.