Merged
Conversation
rekmarks
commented
Oct 8, 2020
| } | ||
|
|
||
| _trackSwapsMetrics (txMeta) { | ||
| if (this._getParticipateInMetrics() && txMeta.swapMetaData) { |
Member
Author
There was a problem hiding this comment.
We check if MetaMetrics are enabled here to save us from unnecessarily computing the metrics data. The trackSegmentEvent function also performs this check as a safety measure.
rekmarks
commented
Oct 8, 2020
Collaborator
Builds ready [157e9df]
Page Load Metrics (581 ± 46 ms)
|
brad-decker
suggested changes
Oct 8, 2020
Gudahtt
reviewed
Oct 8, 2020
brad-decker
previously approved these changes
Oct 8, 2020
Gudahtt
reviewed
Oct 8, 2020
Gudahtt
previously approved these changes
Oct 8, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! One nit but looks good aside from that
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the background, we currently only use Segment to track data about swaps. However, will soon have cause to record other background metrics using Segment.
This PR refactors our use of Segment in the background such that the caller only has to concern themselves with information relevant to the event being tracked, not metadata that's common to all background events. It also cleans up the metrics functionality in the transactions controller and moves it to its own function. The calculation of the various values sent to Segment is unchanged.