Use approval controller for permissions requests#9401
Merged
Conversation
65605ce to
08aa491
Compare
Collaborator
Builds ready [08aa491]
Page Load Metrics (578 ± 94 ms)
|
Closed
44a9977 to
d4557da
Compare
Collaborator
Builds ready [648c7c2]
Page Load Metrics (426 ± 49 ms)
|
648c7c2 to
b01bb6c
Compare
Collaborator
Builds ready [b01bb6c]
Page Load Metrics (445 ± 61 ms)
|
b01bb6c to
274765e
Compare
Collaborator
Builds ready [274765e]
Page Load Metrics (468 ± 61 ms)
|
Member
Author
|
I'm gonna do this on in TypeScript, so reverting to draft until MetaMask/core#289 is merged and we can update Edit: This was done. |
274765e to
efb8c2e
Compare
1b6d7b3 to
59ef71b
Compare
5ab5ed7 to
c50ff31
Compare
Collaborator
Builds ready [c50ff31]
Page Load Metrics (358 ± 46 ms)
|
c50ff31 to
19d492b
Compare
Collaborator
Builds ready [19d492b]
Page Load Metrics (443 ± 77 ms)
|
Collaborator
Builds ready [35007dc]
Page Load Metrics (386 ± 48 ms)
|
Member
|
ApprovalController major version bump MetaMask/core#313 |
35007dc to
e78cefd
Compare
Collaborator
Builds ready [e78cefd]
Page Load Metrics (520 ± 47 ms)
|
Gudahtt
reviewed
Dec 3, 2020
Collaborator
Builds ready [b176c8b]
Page Load Metrics (493 ± 32 ms)
|
brad-decker
previously approved these changes
Dec 10, 2020
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
awesome work, @rekmarks -- the separation of concerns in the permissions controller is super clean.
* Use approval controller for badge updates
b176c8b to
b5b5282
Compare
brad-decker
approved these changes
Dec 14, 2020
Collaborator
Builds ready [b5b5282]
Page Load Metrics (529 ± 14 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the new approval controller to the extension codebase. We use it for the permissions controller's pending approval functionality.
The approval controller sets us up for a new pattern of requesting and managing user confirmations in RPC methods. Along with the generic RPC method middleware, the approval controller will allow us to eliminate our message managers, and decouple these method handlers from our provider stack, making the implementations more portable between the extension and mobile.