Skip to content

Fixes signed type data overflow#9165

Closed
ryanml wants to merge 1 commit intoMetaMask:developfrom
ryanml:fix-signed-overflow
Closed

Fixes signed type data overflow#9165
ryanml wants to merge 1 commit intoMetaMask:developfrom
ryanml:fix-signed-overflow

Conversation

@ryanml
Copy link
Copy Markdown
Contributor

@ryanml ryanml commented Aug 9, 2020

Fixes: #7921, #9123

(Scrollable)
Screen Shot 2020-08-09 at 1 14 38 AM
Screen Shot 2020-08-09 at 1 12 54 AM

@ryanml ryanml requested a review from a team as a code owner August 9, 2020 08:19
@ryanml ryanml requested a review from danjm August 9, 2020 08:19
@danfinlay
Copy link
Copy Markdown
Contributor

Thank you so much for doing this one! Been far too long coming.

Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

&--node-leaf {
display: flex;
span {
display: block;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just read this again. Why is this span set to display: block;? I mean what effect were you trying to achieve.

A display property might not be needed here? And span's with display: block; are basically divs, so if this is necessary it would be better to just change those spans to divs and remove this extra css rule.

Although, I suspect that this was trying to achieve a specific effect, so perhaps something else is needed.

@danjm
Copy link
Copy Markdown
Contributor

danjm commented Aug 14, 2020

Also, when I run this on Chrome (Version 84.0.4147.105) I see the following:

Screenshot from 2020-08-14 10-17-29

It would be best if we could prevent the horizontal scrolling

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Feb 26, 2021

Closed in favour of #10485

@Gudahtt Gudahtt closed this Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

signTypedData_v4 does not overflow:wrap fields.

4 participants