Fix external sourcemaps reference causing error in browser console#8367
Merged
kumavis merged 1 commit intobuild-sys-2from Jan 18, 2021
Merged
Fix external sourcemaps reference causing error in browser console#8367kumavis merged 1 commit intobuild-sys-2from
kumavis merged 1 commit intobuild-sys-2from
Conversation
Collaborator
Builds ready [0ed6409]
Page Load Metrics (677 ± 50 ms)
|
Closed
Member
Author
|
merging this into build-sys-2, which is highly conflicted and wont land as is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #8170
Fixes #8167
current PR target is
build-sys-2to correctly show diffs for thisneed to see if this causes sentry to not be able to parse callstacks. having trouble testing this. may have to merge to test in prod and revert if its a problem