Skip to content

Fix retry transaction#8177

Merged
Gudahtt merged 1 commit intodevelopfrom
restore-retry-transaction
Mar 11, 2020
Merged

Fix retry transaction#8177
Gudahtt merged 1 commit intodevelopfrom
restore-retry-transaction

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Mar 11, 2020

The createRetryTransaction was accidentally removed from the gas-modal-page-container component during a refactor in #7730. Attempting to retry a transaction since that change has resulted in a UI crash.

The `createRetryTransaction` was accidentally removed from the
`gas-modal-page-container` component during a refactor in #7730.
Attempting to retry a transaction since that change has resulted in a
UI crash.
@Gudahtt Gudahtt requested review from tmashuang and whymarrh March 11, 2020 03:08
@Gudahtt Gudahtt requested a review from danjm as a code owner March 11, 2020 03:08
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Mar 11, 2020

This problem isn't in production, as #7730 (where this bug was introduced) hasn't made it into production yet

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [6da2e32]
Page Load Metrics (635 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint368745147
domContentLoaded33276363410249
load33376563510249
domInteractive33176363410249

Copy link
Copy Markdown
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit ad5174a into develop Mar 11, 2020
@whymarrh whymarrh deleted the restore-retry-transaction branch March 11, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants