Implementation for eth_decryptMessage#7247
Implementation for eth_decryptMessage#7247logvik wants to merge 12 commits intoMetaMask:developfrom logvik:develop
Conversation
… keys via keyring and decrypting messages that were encrypted via eth-sig-util. - Need to add translations for all languages, except en and ru - Need to fix issue with badges. The decrypt request does not influence on badges, although code for this part is present. The core team, please review this piece.
eth-json-rpc-middleware has updated on 4.3.0
…ngs for the Russian translation.
This comment has been minimized.
This comment has been minimized.
|
@logvik apologies for the delay in reviewing this—I've assigned myself here to indicate that I'll be helping get this merged. I will fix the conflicts here (most of them were from my work). |
|
Oh, sure, feel free to close this and I'll take a look at that one |
|
@whymarrh , we have a blocked PR's, need to resolve them before I will prepare new PR for the extension: |
|
@logvik The keyring package should probably be updated on those repos, sure, but I don't think those changes are blocking. The version range of that package currently is inclusive of the new version, so we can use those packages as-is from |
|
@Gudahtt I agree, it doesn't block the developing process. But for example, https://github.com/logvik/metamask-extension/blob/develop/package.json#L98 uses my repository with the updated version and due to this circumstance, I can't offer to merge it with metamask-extension. |
|
Yep, understood! What I mean is that you can use the real |
|
@Gudahtt do you mean that in package.json add |
|
Yep, that's basically what I'm saying. It's understandable that you couldn't get it to work though, as it requires manual lockfile manipulation. If you get the rest of the branch updated, I can take care of that part and show you what I mean. |
|
Maybe just simpler to ask team members to update npm and all? Then I will prepare new PR to the metamask-extension.
I can't reach out to @danfinlay. Usually, he did all merges. |
|
Well, updating the lockfile is quite simple 😅 . I'm just not sure how to explain it except by example. |
The new feature, as requested here #1190