feature: integrate gaba/CurrencyRateController#6570
Merged
Conversation
017d780 to
1a808c0
Compare
39a118e to
164fa1c
Compare
Contributor
|
Updated to resolve conflicts post-#6569 |
Contributor
|
This LGTM though we'll need to work out the e2e failures (cc @tmashuang) |
164fa1c to
01d75f8
Compare
Collaborator
Contributor
Author
|
Based on the previous review and approval pending e2e tests passing, figured this was safe to finally land. For posterity, the e2e test failure was because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request integrates
gaba/CurrencyRateControllerand removes the oldCurrencyController.Resolves #6536
Example fiat conversion:
rates:**