Closed
Conversation
MarkOSullivan94
approved these changes
Jun 7, 2019
Contributor
MarkOSullivan94
left a comment
There was a problem hiding this comment.
Tested out the changes and all is working on my end! Great job 👍
Contributor
|
@ContemporaryAnarchy thanks for working on this. Unfortunately this suffers from the same problem my original branch and changes suffered from: the bundle includes this package and we don't yet have a clean way of excluding packages from the bundle. I'm closing this for now, but being able to uses these devtools is something we want to land in MetaMask in the near future. |
Contributor
|
@whymarrh where could I follow updates for devtools integration into MetaMask? |
Contributor
|
@MarkOSullivan94 #6793 supersedes this PR (and #5620) and we're actively working on removing it from the bundle. We're hoping to land this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These proposed changes include an option for developers to enable the React Dev Tools for debugging the UI, as the in-browser option does not work with extensions.