No longer check network when validating checksum addresses#6280
Merged
No longer check network when validating checksum addresses#6280
Conversation
whymarrh
suggested changes
Mar 11, 2019
Contributor
whymarrh
left a comment
There was a problem hiding this comment.
Let's delete the lines instead of commenting them out, we can view the old versions if we need to reference the old implementations
Collaborator
Collaborator
whymarrh
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment out network checking on validating checksum address.
Fixes #6214