Skip to content

Nonmultiple notifications for batch txs#6279

Merged
tmashuang merged 1 commit intodevelopfrom
notification-window
Mar 11, 2019
Merged

Nonmultiple notifications for batch txs#6279
tmashuang merged 1 commit intodevelopfrom
notification-window

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

@tmashuang tmashuang commented Mar 11, 2019

Fixes #6264
Fixes #6273

Will no longer bring the notification to the foreground, but will no longer create multiple notifications for batch txs.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [43f5fd0]: mascara, chrome, firefox, edge, opera

@whymarrh whymarrh requested a review from danjm March 11, 2019 18:20
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmashuang tmashuang merged commit 59dbb9b into develop Mar 11, 2019
@tmashuang tmashuang deleted the notification-window branch March 11, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants