Remove public property from package.json file#6190
Merged
kumavis merged 1 commit intoMetaMask:developfrom Feb 26, 2019
Merged
Conversation
As per the package.json documentation [1] setting `"private": true` in the package.json file is enough for npm to refuse to publish it. The docs don't specify that a `public` key is respected. [1]:https://docs.npmjs.com/files/package.json#private
873625b to
dc00717
Compare
kumavis
approved these changes
Feb 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the
package.jsondocumentation [1] setting"private": truein thepackage.jsonfile is enough for npm to refuse to publish it. The docs don't specify that apublickey is respected.