Skip to content

Fix inpage.js event handler memory leak#6177

Merged
bitpshr merged 1 commit intoMetaMask:developfrom
gkaemmer:fix-inpage-event-listener-leaks
Feb 18, 2019
Merged

Fix inpage.js event handler memory leak#6177
bitpshr merged 1 commit intoMetaMask:developfrom
gkaemmer:fix-inpage-event-listener-leaks

Conversation

@gkaemmer
Copy link
Copy Markdown
Contributor

@gkaemmer gkaemmer commented Feb 17, 2019

Fixes #6176

Confirmed that this properly works:

getEventListeners(window).message.length
// => 3
ethereum._metamask.isApproved()

getEventListeners(window).message.length
// => Still 3

@bdresser bdresser requested a review from bitpshr February 18, 2019 20:35
@bitpshr bitpshr merged commit 89c4353 into MetaMask:develop Feb 18, 2019
@bitpshr
Copy link
Copy Markdown
Contributor

bitpshr commented Feb 18, 2019

Thanks for this @gkaemmer!

@danfinlay danfinlay mentioned this pull request Feb 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bitpshr bitpshr bitpshr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gkaemmer @bitpshr