Skip to content

Metametrics#6171

Merged
danjm merged 50 commits intodevelopfrom
metametrics
Mar 5, 2019
Merged

Metametrics#6171
danjm merged 50 commits intodevelopfrom
metametrics

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Feb 15, 2019 •
edited by JSON-LEE13
Loading

This PR implements the analytics system described here https://medium.com/metamask/metametrics-an-introduction-to-metamasks-new-analytics-system-e9749e74a275

Code related to the sending of metrics can be reviewed. Reviewers may find it easy to review commit by commit.

Outstanding UI tasks include:

  • Add correct chart graphic on opt-in screen
  • Update the opt-in modal (for existing users) to latest designs
  • Apply the responsive design to the opt-in modal
  • Make other first time flow changes on which this will depend
  • Rebase this onto first time flow changes
  • Update tests

peek 2019-02-28 13-04

@danjm danjm requested a review from whymarrh as a code owner February 15, 2019 14:20
@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented Feb 19, 2019

Now with responsive designs

peek 2019-02-18 23-15

@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented Feb 21, 2019

Will rebase onto #6192 once merged

danjm added 18 commits February 27, 2019 13:22
@danjm
Add metametrics provider and util.
058f658
@danjm
Add backend api and state for participating in metametrics.
41e51b3
@danjm
Add frontend action for participating in metametrics.
0849337
@danjm
Add metametrics opt-in screen.
87c06c1
@danjm
Add metametrics events to first time flow.
d39011f
@danjm
Add metametrics events for route changes
29ff3b6
@danjm
Add metametrics events for send and confirm screens
6cf113f
@danjm
Add metametrics events to dropdowns, transactions, log in and out, se…
c29348d 
…ttings, sig requests and main screen
@danjm
Ensures each log in is measured as a new visit by metametrics.
35e3175
@danjm
Ensure metametrics is called with an empty string for dimensions para…
bee4e15 
…ms if specified
@danjm
Adds opt in metametrics modal after unlock for existing users
38ad6e1
@danjm
Adds settings page toggle for opting in and out of MetaMetrics
9ce1182
@danjm
Switch metametrics dimensions to page level scope
e4ced75
@danjm
Lint, test and translation fixes for metametrics.
3284348
@danjm
Update design for metametrics opt-in screen
2132777
@danjm
Complete responsive styling of metametrics-opt-in modal
dc97baf
@danjm
Use new chart image on metrics opt in screens
a1145ea
@danjm
Incorporate the metametrics opt-in screen into the new onboarding flow
88e0cc7
@danjm danjm force-pushed the metametrics branch 3 times, most recently from 5fec1f1 to f507c5f Compare February 28, 2019 12:25
@danjm
Copy link
Copy Markdown
Contributor Author

danjm commented Mar 1, 2019

I think opting IN to metrics is being recorded as opting out

Good catch again. Fixed now.

danjm added 13 commits March 4, 2019 11:44
@danjm
Clean up code related to metametrics.
debd058
@danjm
Fix bad merge conflict resolution and improve promise handling in sen…
d33f434 
…dMetaMetrics event and confrim tx base
@danjm
Don't send a second metrics event if user has gone back during first …
c4ee46d 
…time flow.
@danjm
Collect metametrics on going back from onboarding create/import.
f20eb10
@danjm
Add missing custom variable constants for metametrics
55b09f2
@danjm
Fix metametrics provider
4a74b0a
@danjm
Make height of opt-in modal responsive.
9a6f943
@danjm
Adjust text content for opt-in modal.
8eadc38
@danjm
Update metametrics event names and clean up code in opt-in-modal
8ea5215
@danjm
Put phishing warning step next to last in onboarding flow
8b7b253
@danjm
Link terms of service on create and import screens of first time flow
ae8d9c0
@danjm
Add subtext to options on the onboarding select action screen.
c5641b1
@danjm
Fix styling of bullet points on end of onboarding screen.
d629c2e
@danjm danjm mentioned this pull request Mar 4, 2019
Closed
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 5, 2019

Builds ready [2dbc223]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 5, 2019

Builds ready [53356fd]: mascara, chrome, firefox, edge, opera

@danjm danjm merged commit c757366 into develop Mar 5, 2019
@whymarrh whymarrh deleted the metametrics branch March 5, 2019 18:36
@darkwing darkwing mentioned this pull request Feb 23, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tmashuang tmashuang tmashuang left review comments

@whymarrh whymarrh whymarrh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danjm @tmashuang @danfinlay @bdresser @metamaskbot @whymarrh