Skip to content

Show/Hide Fiat on Testnets based on User Preference#6153

Merged
whymarrh merged 19 commits intoMetaMask:developfrom
chikeichan:hide-fiat-testnets
Feb 26, 2019
Merged

Show/Hide Fiat on Testnets based on User Preference#6153
whymarrh merged 19 commits intoMetaMask:developfrom
chikeichan:hide-fiat-testnets

Conversation

@chikeichan
Copy link
Copy Markdown
Contributor

@chikeichan chikeichan commented Feb 14, 2019 •
edited
Loading

showhide

  • Show/Hide Fiat based on network type for sidebar, transaction-list, transaction-list-item balance display
  • Show/Hide Fiat based on network type for account balance and currency-input on send screen
  • Show/Hide Fiat based on network type for gas selectors on send screen
  • Show/Hide Fiat based on network type for currency-input on send token screen
  • Show/Hide Fiat based on network type for gas selectors on send token screen
  • Show/Hide Fiat based on network type for all balances on confirm screen
  • Show/Hide Fiat based on network type for all balances on confirm token screen
  • Test Show/Hide in Contract Deploy
  • Test Show/Hide in non-send actions (contract calls, sign message, etc)
  • Add New Preference toggle
  • Add Unit Tests

@chikeichan chikeichan added the DO-NOT-MERGE Pull requests that should not be merged label Feb 14, 2019
@chikeichan chikeichan changed the title [DO NOT MERGE] Show/Hide Fiat on Testnets based on User Preference Show/Hide Fiat on Testnets based on User Preference Feb 15, 2019
@chikeichan chikeichan removed the DO-NOT-MERGE Pull requests that should not be merged label Feb 15, 2019
@chikeichan
Copy link
Copy Markdown
Contributor Author

chikeichan commented Feb 21, 2019

  • cherrypicked e2e test fix from @danjm

danjm
danjm previously approved these changes Feb 25, 2019
View reviewed changes
@bdresser bdresser mentioned this pull request Feb 26, 2019
Closed
chikeichan and others added 19 commits February 26, 2019 13:26
@chikeichan @danjm
Hide fiat based on preference for all balance displays
829ae1a
@chikeichan @danjm
Hide fiat in testnets for Send currency input
e18524c
@chikeichan @danjm
Hide Fiat conversion in confirm and gas fee diplay
72cafbb
@chikeichan @danjm
Hide conversion in send token and confirm token
a5108e0
@chikeichan @danjm
Add preference toggle for showing fiat conversion in testnets
328825b
@chikeichan @danjm
Fix linter errors
8922080
@chikeichan @danjm
Fix unit test MetaMask#1
e1f36eb
@chikeichan @danjm
Fix all unit tests
48a566a
@chikeichan @danjm
Add unit test for currency-input component and container
9f61e0f
@chikeichan @danjm
Add unit test for account-list-item component and container
8e8c54d
@chikeichan @danjm
Add unit test for token-input component and container
1457c1b
@chikeichan @danjm
Add unit test for user-preferenced-currency-display.container
2a8ce08
@chikeichan @danjm
Add unit test for custom-gas
8831cdc
@chikeichan @danjm
Add show/hide fiat logic to gas-modal-page-container
e1ec88e
@chikeichan @danjm
Add unit test for gas modal
b3f7ae5
@chikeichan @danjm
Fix linter errors
7283b28
@danjm
Update integration and e2e tests for test-net currency hiding.
7b7866a
@danjm
Fix indeterminant opening of transaction details in tests.
54de2cf
@danjm
Further guard against indeterminate opening of transaction details in…
2d732aa 
… e2e test.

Lint fix.
@danjm danjm force-pushed the hide-fiat-testnets branch from dcc61a0 to 2d732aa Compare February 26, 2019 17:23
@whymarrh whymarrh merged commit a2320c7 into MetaMask:develop Feb 26, 2019
@wbt wbt mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whymarrh whymarrh Awaiting requested review from whymarrh

1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chikeichan @danjm @whymarrh