Add button to force edit token symbol when adding custom token#6147
Merged
whymarrh merged 1 commit intoMetaMask:developfrom Feb 13, 2019
Merged
Add button to force edit token symbol when adding custom token#6147whymarrh merged 1 commit intoMetaMask:developfrom
whymarrh merged 1 commit intoMetaMask:developfrom
Conversation
Contributor
|
LGTM @chikeichan ! unrelated to the PR, but do you see the white background not fit the form in your UI? or is that an artifact of the screen grab |
Contributor
Author
|
@bdresser the jumpy white background was a result of the screen grab tool (low resolution but FREE!) I used - I promise the actual styling looks normal :) Will try to increase screencaps resolution in future PRs. |
Contributor
|
Nah no worries just makin sure it wasn't something we missed! Thanks @chikeichan :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bdresser @cjeria
Took some design liberty on this one to add a "Edit" button when custom token symbol is autofilled. I want to make it an explicit user action that they are editing the token symbol and are diverting from actual data from the token contract. Let me know what you think.