Add Copy Tx ID button to transaction-list-item-details#6146
Merged
whymarrh merged 2 commits intoMetaMask:developfrom Feb 17, 2019
Merged
Add Copy Tx ID button to transaction-list-item-details#6146whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh merged 2 commits intoMetaMask:developfrom
Conversation
whymarrh
suggested changes
Feb 13, 2019
Contributor
There was a problem hiding this comment.
Should we move this into the callback for the above setState call? We'd want this to run after the copy?
Contributor
Author
There was a problem hiding this comment.
yea make sense, i will move it
Contributor
|
LGTM @chikeichan -- does this work out okay when we're also showing the "Cancel" and "Speed Up" buttons? |
danjm
previously approved these changes
Feb 15, 2019
Contributor
danjm
left a comment
There was a problem hiding this comment.
I think this is good to go, once Whymarrh's comment is addressed.
whymarrh
approved these changes
Feb 16, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bdresser @cjeria
See attached gif. I added a "copy to clipboard" to tx detail for user to copy their tx id. I thought this fits the existing UX better than adding another component showing the tx hash. What do you think?