recent-blocks - dont listen for block when on infura providers#6124
Merged
recent-blocks - dont listen for block when on infura providers#6124
Conversation
20dd7ae to
30f25a6
Compare
30f25a6 to
7e64a57
Compare
Collaborator
whymarrh
previously requested changes
Feb 12, 2019
| log.error(err) | ||
| } | ||
| } | ||
| let isListeng = false |
Contributor
There was a problem hiding this comment.
Small typo, should be isListening
tmashuang
suggested changes
Feb 12, 2019
tmashuang
suggested changes
Feb 12, 2019
| isListeng = true | ||
| } | ||
| networkController.on('networkDidChange', (newType) => { | ||
| if (INFURA_PROVIDER_TYPES.includes(newType) && isListeng) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (INFURA_PROVIDER_TYPES.includes(newType) && isListeng) { | |
| if (INFURA_PROVIDER_TYPES.includes(newType) && isListening) { |
| log.error(err) | ||
| } | ||
| } | ||
| let isListeng = false |
Contributor
There was a problem hiding this comment.
Suggested change
| let isListeng = false | |
| let isListening = false |
| } else if ( | ||
| !INFURA_PROVIDER_TYPES.includes(type) && | ||
| type !== 'loading' && | ||
| !isListeng |
Contributor
There was a problem hiding this comment.
Suggested change
| !isListeng | |
| !isListening |
237f859 to
c10fb3c
Compare
Collaborator
tmashuang
approved these changes
Feb 12, 2019
Typo isListeng has been changed to isListening
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will remove the listener off the block tracker when on infura providers sense it is not needed
that will allow the block tracker to stop polling