Skip to content

Prevent send to token#6051

Merged
danfinlay merged 7 commits intodevelopfrom
prevent-send-to-token
Jan 22, 2019
Merged

Prevent send to token#6051
danfinlay merged 7 commits intodevelopfrom
prevent-send-to-token

Conversation

@estebanmino
Copy link
Copy Markdown
Contributor

@estebanmino estebanmino commented Jan 21, 2019

This PR prevents users to send tokens to contract addresses in eth-contract-metadata or tokens added manually.

GIF to show the UX

prevent

The first address is "HACK" address, the second one is one from eth-contract-metadata.

Fixes #3185

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 21, 2019

Builds ready [6dd7b69]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 22, 2019

Builds ready [ce2d48a]: mascara, chrome, firefox, edge, opera

danfinlay
danfinlay approved these changes Jan 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great user protection, thank you!

@danfinlay danfinlay merged commit 1d93d9a into develop Jan 22, 2019
@danfinlay danfinlay deleted the prevent-send-to-token branch January 22, 2019 19:06
@estebanmino estebanmino mentioned this pull request Jan 23, 2019
Merged
@whymarrh whymarrh mentioned this pull request May 8, 2019
Merged
@sime sime mentioned this pull request Dec 19, 2022
Closed
@JiimyZee
Copy link
Copy Markdown

JiimyZee commented Feb 6, 2024

When were any of these "known contract warnings" actually implemented because I can see you all have been working on this since 2016?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2024

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
❌ @estebanmino

@JiimyZee
Copy link
Copy Markdown

JiimyZee commented Feb 6, 2024

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA. ❌ @estebanmino

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danfinlay danfinlay danfinlay approved these changes

@alextsg alextsg Awaiting requested review from alextsg

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warn users when sending tokens to the token address

4 participants

@estebanmino @metamaskbot @JiimyZee @danfinlay