Fix incorrectly showing checksums on non-ETH blockchains#5973
Fix incorrectly showing checksums on non-ETH blockchains#5973jonathansmirnoff wants to merge 18 commits intoMetaMask:developfrom jonathansmirnoff:added-support-rsk
Conversation
|
@whymarrh did you have the chance to review this PR? |
|
Hey @jonathansmirnoff, thanks for this PR! Firstly, can we rebase this on the latest |
|
@whymarrh thanks for your review. I will do the rebase. |
|
@whymarrh is it possible that ci/circleci: test-e2e-beta-drizzle test is not working? |
|
It should be working fine on the latest |
…address if network is RSK
|
@whymarrh I implemented a few changes, I think that now it is more clear the code. I put the logic of the network check in the function So now I pass the networkid to the checksumAddress function. For example: Let me know what do you think about this. Thanks! |
|
I will do another PR to be more clear with the history. |
This PR fix the issue: #5838