Conversation
brunobar79
left a comment
There was a problem hiding this comment.
Adding this comments so I can address before we decide to merge this in
|
There's an important item to note with this feature: Since it hangs a method on the |
|
Ok I've pushed up some comments to help encourage correct future use of the feature flags hash. I'm ok with this being merged if someone approves it now. |
…extension into FeatureFlagMobileSync
whymarrh
left a comment
There was a problem hiding this comment.
Two small things:
- The noted regression (?) in the PreferencesController
- The changes to the
package-lock.jsonfile should probably be dropped and re-added, I'm seeing this PR downgrade the version of json-rpc-engine we're pinned to from 3.8.0 to 3.7.3 which doesn't seem correct.
| featureFlags: { | ||
| betaUI: true, | ||
| skipAnnounceBetaUI: true, | ||
| }, |
There was a problem hiding this comment.
We should drop this addition before merging as this seems to be a regression
… FeatureFlagMobileSync
|
@danfinlay on MM 6.5.3 (FF + Chrome) under Settings > Advanced, the mobile sync is not hidden any more. Does not help with confusion about the "release" of the mobile app medias talked about and malware fake apps :) |
Replaces #5935.
Hides that feature (which doesn't make sense until we have mobile) behind a hidden feature flag.
Adds the ability to set feature flags from the background console using this method:
You can try it out by entering
setPreference('mobileSync', true)in the background console, which will add a new button to the bottom of the settings view.