Skip to content

test - unit - fail if tests contain a .only call#4374

Merged
kumavis merged 1 commit intodevelopfrom
test-unit-fail-on-only
May 30, 2018
Merged

test - unit - fail if tests contain a .only call#4374
kumavis merged 1 commit intodevelopfrom
test-unit-fail-on-only

Conversation

@kumavis
Copy link
Copy Markdown
Member

@kumavis kumavis commented May 25, 2018 •
edited
Loading

.only was accidently committed a couple times, this will catch it in the test suite

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 25, 2018

Builds ready [1cd4b03]: mascara, chrome, firefox, edge, opera

@whymarrh
Copy link
Copy Markdown
Contributor

whymarrh commented May 28, 2018

Instead of introducing a separate tool for this, it might be worth using eslint-plugin-mocha's no-exclusive-tests rule since ESLint is already part of the project.

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented May 29, 2018

we dont currently lint our tests

[11:16:09] ESLintError in plugin 'gulp-eslint'
Message:
    Failed with 303 errors
Details:
    domainEmitter: [object Object]
    domain: [object Object]
    domainThrown: false

adding those will require some fixes

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented May 29, 2018

started a lint rework but it got out of hand #4395

@kumavis
Copy link
Copy Markdown
Member Author

kumavis commented May 29, 2018 •
edited
Loading

@whymarrh lets merge this and then remove it in #4395 whenever that lands
thoughts?

@kumavis kumavis mentioned this pull request May 29, 2018
Closed
@whymarrh
Copy link
Copy Markdown
Contributor

whymarrh commented May 30, 2018 •
edited
Loading

@whymarrh lets merge this and then remove it in #4395 whenever that lands
thoughts?

Sounds good, #4395 looks like a solid start

@kumavis kumavis merged commit 4789e98 into develop May 30, 2018
@kumavis kumavis deleted the test-unit-fail-on-only branch May 30, 2018 04:57
@tmashuang tmashuang mentioned this pull request Jun 28, 2018
Merged
@whymarrh whymarrh mentioned this pull request Oct 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@whymarrh whymarrh whymarrh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumavis @metamaskbot @whymarrh