release(runway): cherry-pick chore: bump @metamask/tron-wallet-snap to 1.25.6#43038
Merged
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 Updated following `e2e` test files to adapt new logic for refresh transaction expiration - `test/e2e/flask/tron-connect/mocks/trongrid.ts` - `test/e2e/flask/tron-connect/common-tron.ts` - `test/e2e/tests/tron/mocks/common-tron.ts` - `test/e2e/flask/tron-connect/signAndSendTrx.spec.ts` - `test/e2e/flask/tron-connect/signAndSendUsdt.spec.ts` <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` n/a 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Ships a snap version that changes pre-sign transaction validation/refresh on Tron send paths; risk is mitigated by e2e mock updates but still affects real signing behavior. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to **`^1.25.6`** (and lockfile) so the extension picks up upstream fixes that **refresh stale Tron transaction fields** (`expiration`, `ref_block_bytes`, `ref_block_hash`) before sign/broadcast. > > E2E mocks are expanded so tests match that behavior: shared block payloads, new handlers for **`getnowblock`**, **`getblockbynum`**, and Infura **`getnowblock`**; broadcast mocks now return success instead of expiration errors; swap/bridge fixture data uses **future-dated** expirations and aligned ref-block values for stable CI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a92c9de. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
vpintorico
approved these changes
May 28, 2026
Contributor
Builds ready [11c7c22]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 10 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/tron-wallet-snapto1.25.6(chore: bump@metamask/tron-wallet-snapto1.25.6#42701)Description
This PR bumps @metamask/tron-wallet-snap from
^1.25.3to^1.25.6.The main purpose of this update is to pull in the latest Tron snap
validation fixes, in particular a mechanism to refresh stale or invalid
expiration,ref_block_bytesandref_block_hashbefore signing inboth send/broadcast paths.
Preview package:
@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5Release:
@metamask-previews/tron-wallet-snap@^1.25.6Upstream PR:
Updated following
e2etest files to adapt new logic for refreshtransaction expiration
test/e2e/flask/tron-connect/mocks/trongrid.tstest/e2e/flask/tron-connect/common-tron.tstest/e2e/tests/tron/mocks/common-tron.tstest/e2e/flask/tron-connect/signAndSendTrx.spec.tstest/e2e/flask/tron-connect/signAndSendUsdt.spec.tsChangelog
CHANGELOG entry: bump the
@metamask/tron-wallet-snapto^1.25.6Related issues
n/a
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Ships a snap version that changes pre-sign transaction
validation/refresh on Tron send paths; risk is mitigated by e2e mock
updates but still affects real signing behavior.
Overview
Bumps
@metamask/tron-wallet-snapfrom^1.25.3to^1.25.6(and lockfile) so the extension picks up upstream fixes that refresh
stale Tron transaction fields (
expiration,ref_block_bytes,ref_block_hash) before sign/broadcast.E2E mocks are expanded so tests match that behavior: shared block
payloads, new handlers for
getnowblock,getblockbynum, andInfura
getnowblock; broadcast mocks now return success instead ofexpiration errors; swap/bridge fixture data uses future-dated
expirations and aligned ref-block values for stable CI.
Reviewed by Cursor Bugbot for commit
a92c9de. Bugbot is set up for automated
code reviews on this repo. Configure
here.
Co-authored-by: gabrieledm gabriele.delmonte@proton.me
Co-authored-by: Gabriele Del Monte 37625739+gabrieledm@users.noreply.github.com
Co-authored-by: Maxime OUAIRY maxime.ouairy-ext@consensys.net 4d85bd5