fix: localized connect message by montelaidev · Pull Request #41417 · MetaMask/metamask-extension

montelaidev · 2026-04-01T13:17:55Z

Description

This PR fixes the to use a localized message for the loading text in the Connect Hardware flow.

Changelog

CHANGELOG entry: Localize Looking for your <device> mesage

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1403?atlOrigin=eyJpIjoiNWM4YjJlMmIxZWNiNGU2MmEwZTA1N2ZiMjMzZTI0YWYiLCJwIjoiaiJ9

Manual testing steps

Go to add hardware wallet
Connect a ledger device
See the loading message as Looking for Ledger

Screenshots/Recordings

No visual difference.

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: only changes the loading indicator string for hardware wallet connection and adjusts unit tests and locale files; no business logic or security-sensitive flows are modified.

Overview
Uses a new i18n key (hardwareWalletLookingForDevice) to render the Connect Hardware loading indicator instead of a hardcoded English string.

Adds the corresponding locale entries (US/GB English) and updates connectHardware action tests to pass a translation function and assert the localized loading message.

^{Written by Cursor Bugbot for commit 430ea29. This will update automatically on new commits. Configure here.}

github-actions · 2026-04-01T13:18:07Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-04-01T13:52:03Z

Builds ready [84a5732]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): e40e8c1 | Date: 2/20/58219 | Pipeline: 23850615575 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount 🟢 [Show logs]
confirmTx 🟢 [Show logs]
bridgeUserActions 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ loadNewAccount/load_new_account: +17%
↑ loadNewAccount/total: +17%

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/initialActions: -29%
↑ startupPowerUserHome/domInteractive: +14%
↑ startupPowerUserHome/backgroundConnect: +24%
↑ startupPowerUserHome/setupStore: +12%
↑ startupPowerUserHome/numNetworkReqs: +48%
↓ startupStandardHome/firstPaint: -23%
↓ startupPowerUserHome/numNetworkReqs: -11%
↑ startupStandardHome/initialActions: +67%
↓ startupPowerUserHome/backgroundConnect: -12%
↓ startupPowerUserHome/setupStore: -24%
↑ startupStandardHome/initialActions: +43%
↓ startupStandardHome/setupStore: -12%
↑ startupPowerUserHome/setupStore: +26%

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟢 [Show logs]
solanaAssetDetails 🟢 [Show logs]
importSrpHome 🟢 [Show logs]
sendTransactions 🟢 [Show logs]
swap 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/doneButtonToHomeScreen: -75%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +63%
↓ onboardingImportWallet/total: -38%
↑ onboardingNewWallet/agreeButtonToOnboardingSuccess: +26%
↓ onboardingNewWallet/doneButtonToAssetList: -30%
↓ onboardingNewWallet/total: -24%
↓ assetDetails/assetClickToPriceChart: -39%
↓ assetDetails/total: -39%
↓ solanaAssetDetails/assetClickToPriceChart: -50%
↓ solanaAssetDetails/total: -50%
↑ importSrpHome/loginToHomeScreen: +17%
↓ importSrpHome/openAccountMenuAfterLogin: -56%
↓ importSrpHome/homeAfterImportWithNewWallet: -44%
↓ importSrpHome/total: -39%
↓ swap/openSwapPageFromHome: -87%
↑ swap/fetchAndDisplaySwapQuotes: +30%
↑ swap/total: +14%

🌐 Dapp Page Load Benchmarks

Current Commit: 84a5732 | Date: 4/1/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 734ms (±36ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 86ms (±11ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	38ms	1.02s	1.34s	1.07s	1.34s
domContentLoaded	734ms	36ms	714ms	1.01s	761ms	1.01s
firstPaint	86ms	11ms	64ms	184ms	96ms	184ms
firstContentfulPaint	86ms	11ms	64ms	184ms	96ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.4 MiB (-20.49%)
ui: -164.04 KiB (-1.92%)
common: 940.74 KiB (8.1%)

metamaskbotv2 · 2026-04-01T19:00:13Z

Builds ready [430ea29]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 2 warn · 🔴 0 fail)

Baseline (latest main): 084a8a9 | Date: 9/20/58219 | Pipeline: 23864262048 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount
🟡 load_new_account
[Show logs]
confirmTx 🟢 [Show logs]
bridgeUserActions 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ loadNewAccount/load_new_account: +14%
↑ loadNewAccount/total: +14%

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
🟡 loadScripts
[Show logs]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/initialActions: +43%
↓ startupPowerUserHome/backgroundConnect: -32%
↓ startupPowerUserHome/initialActions: -17%
↓ startupStandardHome/domInteractive: -12%
↑ startupStandardHome/setupStore: +13%
↑ startupPowerUserHome/numNetworkReqs: +36%
↑ startupStandardHome/domInteractive: +15%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/setupStore: -19%
↑ startupPowerUserHome/domInteractive: +10%
↓ startupPowerUserHome/backgroundConnect: -14%
↓ startupPowerUserHome/setupStore: -13%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/setupStore: -29%
↓ startupPowerUserHome/domInteractive: -23%

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟢 [Show logs]
solanaAssetDetails 🟢 [Show logs]
importSrpHome 🟢 [Show logs]
sendTransactions 🟢 [Show logs]
swap 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ onboardingImportWallet/metricsToWalletReadyScreen: +22%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +43%
↓ onboardingImportWallet/total: -39%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -20%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -23%
↓ onboardingNewWallet/doneButtonToAssetList: -21%
↓ onboardingNewWallet/total: -17%
↓ assetDetails/assetClickToPriceChart: -24%
↓ assetDetails/total: -24%
↓ solanaAssetDetails/assetClickToPriceChart: -64%
↓ solanaAssetDetails/total: -64%
↑ importSrpHome/loginToHomeScreen: +22%
↓ importSrpHome/homeAfterImportWithNewWallet: -43%
↓ importSrpHome/total: -36%
↓ swap/openSwapPageFromHome: -87%
↑ swap/fetchAndDisplaySwapQuotes: +29%

🌐 Dapp Page Load Benchmarks

Current Commit: 430ea29 | Date: 4/1/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±69ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 730ms (±68ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±10ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	69ms	992ms	1.30s	1.24s	1.30s
domContentLoaded	730ms	68ms	692ms	989ms	931ms	989ms
firstPaint	83ms	10ms	64ms	160ms	92ms	160ms
firstContentfulPaint	83ms	10ms	64ms	160ms	92ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 144 Bytes (0%)

sonarqubecloud · 2026-04-01T21:10:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix: localized connect message

84a5732

montelaidev self-assigned this Apr 1, 2026

montelaidev added the team-accounts-framework Accounts team label Apr 1, 2026

montelaidev temporarily deployed to pr-comment April 1, 2026 13:18 — with GitHub Actions Inactive

github-actions Bot added the size-S label Apr 1, 2026

mathieuartu approved these changes Apr 1, 2026

View reviewed changes

montelaidev temporarily deployed to pr-comment April 1, 2026 13:47 — with GitHub Actions Inactive

montelaidev enabled auto-merge April 1, 2026 13:51

gantunesr approved these changes Apr 1, 2026

View reviewed changes

montelaidev added this pull request to the merge queue Apr 1, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026

gantunesr added this pull request to the merge queue Apr 1, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026

gantunesr added this pull request to the merge queue Apr 1, 2026

gantunesr removed this pull request from the merge queue due to a manual request Apr 1, 2026

Merge branch 'main' into fix/mul-1403

430ea29

gantunesr temporarily deployed to pr-comment April 1, 2026 18:26 — with GitHub Actions Inactive

gantunesr temporarily deployed to pr-comment April 1, 2026 18:55 — with GitHub Actions Inactive

gantunesr added this pull request to the merge queue Apr 1, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 1, 2026

montelaidev added this pull request to the merge queue Apr 1, 2026

Merged via the queue into main with commit 0b94eec Apr 1, 2026
390 of 394 checks passed

montelaidev deleted the fix/mul-1403 branch April 1, 2026 23:34

github-actions Bot locked and limited conversation to collaborators Apr 1, 2026

metamaskbot added the release-13.26.0 Issue or pull request that will be included in release 13.26.0 label Apr 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: localized connect message#41417

fix: localized connect message#41417
montelaidev merged 2 commits into
mainfrom
fix/mul-1403

montelaidev commented Apr 1, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 1, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 Bot commented Apr 1, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud Bot commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

montelaidev commented Apr 1, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

metamaskbotv2 Bot commented Apr 1, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbotv2 Bot commented Apr 1, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud Bot commented Apr 1, 2026

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

montelaidev commented Apr 1, 2026 •

edited by cursor Bot

Loading