test: Pass new input for Feature Flag Sync PROD job#41382
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [14cfd11]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 1 warn · 🔴 0 fail)
Dapp page load benchmarks: data not available. Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [022fe50]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 1 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Builds ready [8bcf747]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Builds ready [9bef239]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 1 warn · 🔴 1 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
Builds ready [eabafd4]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 2 warn · 🔴 0 fail)
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|




Description
Reason: Callers of
create-pr-feature-flag-registry-driftneeded more than one GitHub label on the sync PR and sometimes a different title prefix than the hard-coded[QA] Sync Feature Flag Registrystring, while still keeping the UTC timestamp in the title.Solution:
pr-labelon commas and newlines, trimming whitespace, and passing one--labelper value togh pr create.pr-title-prefix(wired asPR_TITLE_PREFIX) so the PR title becomes"${PR_TITLE_PREFIX} - $TIMESTAMP".Files:
.github/workflows/create-pr-feature-flag-registry-drift.ymlonly.Note: This commit sets
pr-title-prefixdefault totest: Sync Feature Flag Registry. If the intended default for production is[QA] Sync Feature Flag Registry, update the workflow default before merge.Changelog
CHANGELOG entry: Extended the feature-flag registry drift reusable workflow to support multiple PR labels and an optional PR title prefix (timestamp suffix unchanged).
Related issues
Fixes: N/A
Manual testing steps
pr-labelwith comma-separated values (e.g.team-qa, other-label) and confirm both labels appear on the opened PR.pr-labeland confirm each line becomes a label.pr-title-prefixand confirm the PR title is{prefix} - {UTC timestamp}.pr-title-prefixand confirm the default prefix from the workflow is used.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Workflow-only change that tweaks metadata (title/labels) on auto-created PRs; no production runtime code is affected.
Overview
Updates the PROD
check-feature-flag-registry-driftGitHub Actions workflow to pass new inputs into the reusablecreate-pr-feature-flag-registry-driftworkflow.Drift PRs created by this job will now use a configurable title prefix (
test: Sync Feature Flag Registry) and apply multiple labels (team-qaandno-changelog).Written by Cursor Bugbot for commit eabafd4. This will update automatically on new commits. Configure here.