fix(ui): reload extension safely from error Try again in popup by gauthierpetetin · Pull Request #41364 · MetaMask/metamask-extension

gauthierpetetin · 2026-03-30T15:30:59Z

Description

Clicking Try again on the global error screen or Shield API error UI used to call browser.runtime.reload() from the extension UI document. In Chromium, that can leave a popup-style window showing normal tab content (e.g. the new-tab page) instead of restarting MetaMask cleanly (GitHub issue #29151).

This change routes recovery through requestSafeReload in the service worker: persistence is flushed, runtime.reload() is scheduled after a short delay, and reloadExtensionFromUi calls requestSafeReload then window.close() so the window is dismissed before reload. Error page and API error handler Try again actions use the shared helper instead of calling browser.runtime.reload() directly.

Changelog

CHANGELOG entry: Fixed an issue where choosing Try again on some error screens could show the browser’s default page inside the MetaMask window instead of restarting the extension.

Related issues

Fixes: #29151

Manual testing steps

Build extension withyarn start and open it.
Use https://metamask.github.io/test-dapp/ → Connect → Malformed signatures → Invalid type → expand Message on the confirmations screen → confirm the error screen appears.
Click Try again: the popup should close and the extension should reload; the popup should not show your browser’s home/new-tab page inside MetaMask.
Optional: Settings → Developer options → Generate a page crash (expanded view) → Try again and confirm recovery still works.

Screenshots/Recordings

Before

fix.ui._.reload.extension.safely.from.error.Try.again.in.popup.by.gauthierpetetin.Pull.Request.41364.MetaMask_metamask-extension.-.31.March.2026.mp4

After

fix.ui._.reload.extension.safely.from.error.Try.again.in.popup.by.gauthierpetetin.Pull.Request.41364.MetaMask_metamask-extension.-.31.March.2026.1.mp4

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, localized change to reload sequencing and UI event handlers; main risk is timing-sensitive reload behavior across extension surfaces.

Overview
Fixes UI-triggered extension reloads to avoid Chromium popup/notification windows briefly showing normal tab content. requestSafeReload now delays runtime.reload() slightly after flushing pending persistence writes, and UI surfaces (Error Page and Shield API error handler) route “Try again” through a new reloadExtensionFromUi helper that calls requestSafeReload then window.close(), with a fallback to direct runtime.reload() if the background request fails.

Adds unit coverage for the new helper and updates existing error-page tests to assert the helper is invoked instead of calling browser.runtime.reload() directly.

^{Written by Cursor Bugbot for commit 81493dc. This will update automatically on new commits. Configure here.}

- Defer runtime.reload in requestSafeReload after persistence flush - Add reloadExtensionFromUi helper (requestSafeReload + window.close) - Use helper on error page and Shield API error handler Fixes #29151 Made-with: Cursor

github-actions · 2026-03-30T15:31:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-30T16:06:25Z

Builds ready [97a55c6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 1114 1009 1186 66 1147 1186
total 1114 1009 1186 66 1147 1186
Confirm Tx confirm_tx 6026 6000 6045 17 6036 6045
total 6026 6000 6045 17 6036 6045
Bridge User Actions bridge_load_page 321 263 383 43 354 383
bridge_load_asset_picker 225 150 316 75 312 316
bridge_search_token 855 815 899 32 868 899
total 1376 1193 1499 108 1470 1499

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Startup Standard Home uiStartup 1499 1261 1822 101 1553 1655
load 1231 1025 1526 91 1281 1343
domContentLoaded 1223 1018 1514 90 1274 1327
domInteractive 28 17 144 16 29 48
firstPaint 176 70 364 80 245 314
backgroundConnect 212 186 279 13 216 237
firstReactRender 20 13 46 5 22 30
initialActions 1 0 6 1 2 4
loadScripts 1028 838 1314 87 1078 1127
setupStore 13 7 30 5 15 24
numNetworkReqs 35 31 59 7 38 49
Startup Power User Home uiStartup 4386 1800 15890 2165 5415 7300
load 1342 1165 3355 287 1352 1622
domContentLoaded 1319 1143 3342 283 1307 1536
domInteractive 38 21 271 34 38 74
firstPaint 260 88 1500 206 297 340
backgroundConnect 1495 303 12469 1791 2404 3826
firstReactRender 25 18 49 6 26 39
initialActions 1 0 3 1 1 3
loadScripts 1096 945 3111 233 1101 1285
setupStore 16 7 41 8 19 33
numNetworkReqs 232 109 435 70 266 350

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 217 216 219 1 218 219
srpButtonToSrpForm 96 93 101 3 99 101
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 1097 1029 1179 59 1144 1179
openAccountMenuToAccountListLoaded 2617 2493 2709 99 2693 2709
total 4083 4005 4177 59 4109 4177
Onboarding New Wallet createWalletToSocialScreen 218 217 219 1 218 219
srpButtonToPwForm 106 106 107 0 107 107
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 39 37 42 2 40 42
agreeButtonToOnboardingSuccess 16 15 17 1 16 17
doneButtonToAssetList 938 512 1254 316 1194 1254
total 1325 897 1644 319 1581 1644
Asset Details assetClickToPriceChart 101 97 106 4 106 106
total 101 97 106 4 106 106
Solana Asset Details assetClickToPriceChart 61 50 72 9 71 72
total 61 50 72 9 71 72
Import Srp Home loginToHomeScreen 2220 2200 2239 18 2237 2239
openAccountMenuAfterLogin 47 38 54 5 49 54
homeAfterImportWithNewWallet 9335 9281 9377 40 9377 9377
total 11645 11527 11790 94 11639 11790
Send Transactions openSendPageFromHome 22 20 25 2 22 25
selectTokenToSendFormLoaded 24 21 30 3 25 30
reviewTransactionToConfirmationPage 854 837 868 11 866 868
total 903 884 926 16 916 926
Swap openSwapPageFromHome 50 31 70 17 69 70
fetchAndDisplaySwapQuotes 2695 2693 2697 2 2697 2697
total 2737 2726 2764 16 2730 2764

🌐 Dapp Page Load Benchmarks

Current Commit: 97a55c6 | Date: 3/30/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 730ms (±38ms) 🟢 | historical mean value: 725ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±10ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.01s	1.35s	1.07s	1.35s
domContentLoaded	730ms	38ms	705ms	1.02s	757ms	1.02s
firstPaint	85ms	10ms	68ms	168ms	92ms	168ms
firstContentfulPaint	85ms	10ms	68ms	168ms	92ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 101 Bytes (0%)
ui: 591 Bytes (0.01%)
common: 20 Bytes (0%)

seaona · 2026-03-31T09:27:41Z

The fix works fine 🙌

fix-reload.mov

DDDDDanica · 2026-04-01T13:19:50Z

LGTM !

sonarqubecloud · 2026-04-02T09:49:07Z

Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-04-02T10:08:26Z

Builds ready [81493dc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 0 warn · 🔴 0 fail)

Baseline (latest main): 8125dd2 | Date: 6/5/58221 | Pipeline: 23894070436 | Baseline logs

Interaction Benchmarks

Benchmark chrome-browserify
loadNewAccount 🟢 [Show logs]
confirmTx 🟢 [Show logs]
bridgeUserActions 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ bridgeUserActions/bridge_load_page: +13%

Startup Benchmarks

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/initialActions: +43%
↑ startupPowerUserHome/domInteractive: +11%
↓ startupPowerUserHome/backgroundConnect: -17%
↓ startupPowerUserHome/numNetworkReqs: -12%
↑ startupPowerUserHome/firstPaint: +15%
↑ startupPowerUserHome/setupStore: +10%
↑ startupPowerUserHome/numNetworkReqs: +29%
↑ startupStandardHome/initialActions: +43%
↓ startupPowerUserHome/domInteractive: -13%
↑ startupPowerUserHome/setupStore: +12%
↑ startupStandardHome/initialActions: +11%
↓ startupStandardHome/setupStore: -27%
↑ startupPowerUserHome/backgroundConnect: +15%

User Journey Benchmarks

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟢 [Show logs]
solanaAssetDetails 🟢 [Show logs]
importSrpHome 🟢 [Show logs]
sendTransactions 🟢 [Show logs]
swap 🟢 [Show logs]

📈 Results compared to the previous 5 runs on main
↑ onboardingImportWallet/metricsToWalletReadyScreen: +19%
↓ onboardingImportWallet/doneButtonToHomeScreen: -77%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +51%
↓ onboardingImportWallet/total: -38%
↓ onboardingNewWallet/doneButtonToAssetList: -25%
↓ onboardingNewWallet/total: -21%
↓ assetDetails/assetClickToPriceChart: -25%
↓ assetDetails/total: -25%
↓ solanaAssetDetails/assetClickToPriceChart: -39%
↓ solanaAssetDetails/total: -39%
↓ importSrpHome/openAccountMenuAfterLogin: -33%
↓ importSrpHome/homeAfterImportWithNewWallet: -46%
↓ importSrpHome/total: -42%
↓ swap/openSwapPageFromHome: -84%
↑ swap/fetchAndDisplaySwapQuotes: +37%
↑ swap/total: +16%

🌐 Dapp Page Load Benchmarks

Current Commit: 81493dc | Date: 4/2/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 725ms (±37ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 85ms (±14ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.00s	1.31s	1.07s	1.31s
domContentLoaded	725ms	37ms	700ms	999ms	755ms	999ms
firstPaint	85ms	14ms	68ms	196ms	96ms	196ms
firstContentfulPaint	85ms	14ms	68ms	196ms	96ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 101 Bytes (0%)
ui: 589 Bytes (0.01%)
common: 20 Bytes (0%)

gauthierpetetin temporarily deployed to pr-comment March 30, 2026 15:31 — with GitHub Actions Inactive

metamaskbot added the team-extension-platform Extension Platform team label Mar 30, 2026

gauthierpetetin self-assigned this Mar 30, 2026

github-actions Bot added the size-S label Mar 30, 2026

gauthierpetetin temporarily deployed to pr-comment March 30, 2026 16:01 — with GitHub Actions Inactive

gauthierpetetin marked this pull request as ready for review March 31, 2026 08:22

gauthierpetetin temporarily deployed to pr-comment March 31, 2026 08:22 — with GitHub Actions Inactive

gauthierpetetin added this to PR review queue Mar 31, 2026

github-project-automation Bot moved this to Needs dev review in PR review queue Mar 31, 2026

DDDDDanica approved these changes Apr 1, 2026

View reviewed changes

Merge branch 'main' into fix/29151-error-try-again-reload

81493dc

gauthierpetetin temporarily deployed to pr-comment April 2, 2026 09:35 — with GitHub Actions Inactive

gauthierpetetin temporarily deployed to pr-comment April 2, 2026 10:03 — with GitHub Actions Inactive

itsyoboieltr approved these changes Apr 2, 2026

View reviewed changes

github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 2, 2026