fix: cp-13.25.0 update get/buy cta list item styling to match mobile design / cta segment prop update#41226
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (3 files, +60 -45)
👨🔧 @MetaMask/metamask-earn (11 files, +481 -109)
|
Builds ready [0e26c15]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Builds ready [52cc586]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Jwhiles
left a comment
There was a problem hiding this comment.
Generally looks good - but I think there's a bit of dead code and confusing naming being introduced. Would be good to clean up a bit.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Builds ready [e1e1b5f]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4647946]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…sign-with-single-convert-mobile-figma
Builds ready [9a38179]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…sign-with-single-convert-mobile-figma
Builds ready [4548825]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…sign-with-single-convert-mobile-figma
|
Builds ready [9aa0d85]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|




Description
Buy/Get Cta Style Alignment
Adjust the token-list mUSD banner so the bonus subtitle uses primary text
color and the action control is a secondary (outline) button instead of
primary.
Segment event prop updates for Claim CTA location and Convert CTA 2&3 redirectTo
Changelog
CHANGELOG entry: Updated Buy/Get mUSD CTA styling
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MUSD-556
Fixes: https://consensyssoftware.atlassian.net/browse/MUSD-558
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Medium risk due to cross-component changes to mUSD CTA/claim analytics payloads and
TokenCellprop shape, which could affect event tracking and CTA visibility if misconfigured.Overview
Updates the home token-list mUSD banner copy/styling to match mobile: headline now uses the product name ("MetaMask USD"), subtitle uses the new
musdEarnBonusPercentagestring, and the action is a secondary button while keeping the row clickable.Refactors
TokenCellmUSD integration from boolean flags to a singlemusdoptions prop (with exported presets for token list and asset overview), and uses that to gate the Merkl claim badge and convert link plus their analytics locations/entry points.Standardizes mUSD analytics across
MusdBuyGetCta,MusdAssetCta,MusdConvertLink, andClaimBonusBadge: events now includeredirects_toderived from education/buy intent, correct network/asset fields (network_chain_id,network_name,asset_symbol), and consistent location mapping; adds/updates tests and snapshots accordingly.Written by Cursor Bugbot for commit 9aa0d85. This will update automatically on new commits. Configure here.