Skip to content

chore: test "fix: disable scanning of unsupported transactions" from Tron Snap#41046

Closed
ulissesferreira wants to merge 1 commit into
mainfrom
chore/test-tron-snap-1.24.0-preview
Closed

chore: test "fix: disable scanning of unsupported transactions" from Tron Snap#41046
ulissesferreira wants to merge 1 commit into
mainfrom
chore/test-tron-snap-1.24.0-preview

Conversation

@ulissesferreira

@ulissesferreira ulissesferreira commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps @metamask/tron-wallet-snap to 1.24.0 and adds a yarn resolution to load the preview build @metamask-previews/tron-wallet-snap@1.24.0-preview-1c14162 for CI / QA validation before the final release is published.

Note: The yarn resolution must be removed before merging. This PR is for testing only.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Manual testing steps

  1. Build the extension (yarn start or yarn dist)
  2. Load it in Chrome and verify Tron wallet functionality works as expected with the snap preview build

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Bump @metamask/tron-wallet-snap to 1.24.0 and add a yarn resolution
to load @metamask-previews/tron-wallet-snap@1.24.0-preview-1c14162
for testing purposes.

Made-with: Cursor
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-networks PRs from the Networks team label Mar 19, 2026
@ulissesferreira ulissesferreira changed the title chore: test @metamask/tron-wallet-snap 1.24.0 preview build chore: test "fix: disable scanning of unsupported transactions" from Tron Snap Mar 19, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​tron-wallet-snap@​1.22.1 ⏵ 1.24.0-preview-1c14162100 +1100100 +5100 +2100

View full report

@sonarqubecloud

Copy link
Copy Markdown

@metamaskbotv2

metamaskbotv2 Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f35bd3f]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29127331717296317
total29127331717296317
Confirm Txconfirm_tx6086606561061660976106
total6086606561061660976106
Bridge User Actionsbridge_load_page28120834648301346
bridge_load_asset_picker26723829426292294
bridge_search_token75471878623765786
total12791121138110013561381
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup15711291187712216501759
load13131055157211114031473
domContentLoaded13041051156710813921464
domInteractive291796192683
firstPaint163711373145228290
backgroundConnect22820942223231259
firstReactRender19124162031
initialActions106114
loadScripts1093847134510811781249
setupStore1474971522
numNetworkReqs393186164080
Power User HomeuiStartup64932379180173574673417117
load13531160229817213991694
domContentLoaded13341151225016613681673
domInteractive42202704336149
firstPaint240812265226302400
backgroundConnect3101369149553554377613900
firstReactRender25164652734
initialActions106112
loadScripts1097936198715511151413
setupStore1764572033
numNetworkReqs22910639559262329
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2182172191218219
srpButtonToSrpForm92919419294
confirmSrpToPwForm23222722527
pwFormToMetricsScreen15151601616
metricsToWalletReadyScreen15151501515
doneButtonToHomeScreen60958265729606657
openAccountMenuToAccountListLoaded292329122928729272928
total3878385439001939003900
Onboarding New WalletcreateWalletToSocialScreen2222202252224225
srpButtonToPwForm1191101287126128
createPwToRecoveryScreen999099
skipBackupToMetricsScreen41394324143
agreeButtonToOnboardingSuccess18171801818
doneButtonToAssetList50348052116512521
total91588195227926952
Asset DetailsassetClickToPriceChart735191158191
total735191158191
Solana Asset DetailsassetClickToPriceChart964017057162170
total964017057162170
Import Srp HomeloginToHomeScreen2362227024215323942421
openAccountMenuAfterLogin684895188095
homeAfterImportWithNewWallet63955273672711736
total30692903319811031783198
Send TransactionsopenSendPageFromHome30243963239
selectTokenToSendFormLoaded31254063140
reviewTransactionToConfirmationPage1158902138420713761384
total1226993145220214411452
SwapopenSwapPageFromHome12010313512122135
fetchAndDisplaySwapQuotes2693268327071127062707
total2799273628413728292841
🌐 Dapp Page Load Benchmarks

Current Commit: f35bd3f | Date: 3/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.10s (±98ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 782ms (±105ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 97ms (±141ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.10s 98ms 1.05s 1.57s 1.41s 1.57s
domContentLoaded 782ms 105ms 732ms 1.42s 1.08s 1.42s
firstPaint 97ms 141ms 64ms 1.50s 96ms 1.50s
firstContentfulPaint 97ms 141ms 64ms 1.50s 96ms 1.50s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 9.04 KiB (0.11%)
  • common: 471 Bytes (0%)

@ulissesferreira ulissesferreira deleted the chore/test-tron-snap-1.24.0-preview branch April 6, 2026 10:30
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-XS team-networks PRs from the Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants