chore: simplify benchmark workflow and consolidate stats storage#41021
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [35f46a6]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
35f46a6 to
e4b0d73
Compare
Contributor
Builds ready [e4b0d73]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
itsyoboieltr
previously approved these changes
Mar 19, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
… stats storage dropped release branch support
|
Contributor
Builds ready [bada820]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
itsyoboieltr
approved these changes
Mar 19, 2026
MajorLift
approved these changes
Mar 19, 2026
| retention-days: 7 | ||
| if-no-files-found: ignore | ||
|
|
||
| dapp-page-load-benchmark: |
Contributor
There was a problem hiding this comment.
Shall we delete ./.github/workflows/dapp-page-load-benchmark.yml to avoid code duplication?
Or is it still needed for something?
Contributor
Author
There was a problem hiding this comment.
Oh good point gonna address in another PR !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dapp-page-load-benchmarkandstore-benchmark-statsmoved frommain.ymlintorun-benchmarks.ymlas inline jobsstore-benchmark-statsnow correctly waits on all three benchmark jobs (benchmarks,benchmarks-webpack-perf,dapp-page-load-benchmark) as siblings, previously it ran in parallel with the dapp benchmarkactions/upload-artifactstep tobenchmarks-webpack-perfso its results are collected bystore-benchmark-statssend-to-sentry.ts) restricted tomain/release/*pushes onlyChangelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
CI benchmark execution and reporting flow is refactored (jobs moved/rewired and new artifact publishing), which can break benchmark visibility or gating if misconfigured, but it doesn’t touch production code.
Overview
Moves
dapp-page-load-benchmarkandstore-benchmark-statsout ofmain.ymland intorun-benchmarks.yml, consolidating benchmark execution and stats publishing under the called workflow.Updates benchmark results handling so
store-benchmark-statswaits for all benchmark jobs (including webpack perf and dapp page-load) and can collect results via newly uploadedbenchmark-*.jsonartifacts, then commits both performance and page-load data toextension_benchmark_statsonmain/release/*pushes.Restricts benchmark Sentry reporting to
main/release/*and wiresEXTENSION_BENCHMARK_STATS_TOKENthrough the workflow call secrets.Written by Cursor Bugbot for commit bada820. This will update automatically on new commits. Configure here.