fix: fall back to blind signing when clear signing not supported by Ledger device by danroc · Pull Request #41017 · MetaMask/metamask-extension

danroc · 2026-03-18T16:03:54Z

Description

signTypedData previously used only signEIP712Message (clear signing), which is not supported on Ledger Nano S. This change adds a fallback: if the device returns INS_NOT_SUPPORTED, it computes the EIP-712 domain separator and message struct hashes and calls signEIP712HashedMessage (blind signing) instead. This mirrors Ledger Live's approach and restores EIP-712 signing compatibility with Ledger Nano S.

Changelog

CHANGELOG entry: Fixed EIP-712 typed data signing for Ledger Nano S devices

Related issues

Fixes: #39983

Manual testing steps

Connect a Ledger Nano S and attempt to sign EIP-712 typed data (e.g. a permit signature)
Confirm signing completes successfully using the blind signing fallback
Connect a Ledger Nano X or Stax and confirm clear signing still works as before

Screenshots/Recordings

Before

Screen.Recording.2026-03-18.at.17.44.13.mov

After

Screen.Recording.2026-03-18.at.17.42.07.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes EIP-712 signing behavior for Ledger devices by adding a clear-signing fallback path that computes hashes locally and uses signEIP712HashedMessage; incorrect hash computation or error classification could cause signature failures on some devices.

Overview
Restores EIP-712 typed-data signing on Ledger devices that don’t support clear signing by catching INS_NOT_SUPPORTED from signEIP712Message and falling back to signEIP712HashedMessage using locally computed domain/message struct hashes.

Adds helpers in app/offscreen/ledger.ts to detect the specific Ledger error and compute EIP-712 hashes via @metamask/eth-sig-util, and expands ledger.test.ts to cover clear-sign success, the INS_NOT_SUPPORTED fallback, and non-fallback error propagation.

^{Written by Cursor Bugbot for commit 10515dd. This will update automatically on new commits. Configure here.}

Add INS_NOT_SUPPORTED fallback in signTypedData: try clear signing (signEIP712Message) first; if the device doesn't support it, compute EIP-712 domain and message hashes and use signEIP712HashedMessage instead. Mirrors Ledger Live's approach and restores compatibility with Ledger Nano S.

github-actions · 2026-03-18T16:05:41Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-18T16:41:47Z

Builds ready [6d556cc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 281 275 286 6 286 286
total 281 275 286 6 286 286
Confirm Tx confirm_tx 6013 6009 6017 3 6015 6017
total 6013 6009 6017 3 6015 6017
Bridge User Actions bridge_load_page 259 223 307 29 275 307
bridge_load_asset_picker 240 214 266 18 255 266
bridge_search_token 766 738 800 22 767 800
total 1255 1227 1293 24 1252 1293

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1509 1241 1945 117 1594 1700
load 1262 1043 1610 112 1354 1459
domContentLoaded 1255 1038 1602 110 1339 1441
domInteractive 28 16 121 21 24 87
firstPaint 170 72 432 87 233 309
backgroundConnect 220 201 256 10 225 240
firstReactRender 18 13 35 4 20 25
initialActions 1 0 10 1 2 3
loadScripts 1050 836 1383 109 1136 1230
setupStore 13 8 39 5 15 22
numNetworkReqs 39 31 83 16 34 80
Power User Home uiStartup 5609 2128 15077 2430 6539 9085
load 1344 1146 1880 145 1368 1663
domContentLoaded 1323 1130 1873 129 1343 1596
domInteractive 46 22 534 63 34 136
firstPaint 214 88 642 95 292 343
backgroundConnect 2152 292 12058 2071 2902 5469
firstReactRender 33 17 294 42 29 35
initialActions 1 0 7 1 1 4
loadScripts 1086 923 1617 116 1104 1293
setupStore 18 6 81 12 18 40
numNetworkReqs 139 68 278 43 144 245

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 221 219 222 1 222 222
srpButtonToSrpForm 95 94 96 1 96 96
confirmSrpToPwForm 22 22 23 0 23 23
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 633 594 688 40 675 688
openAccountMenuToAccountListLoaded 2939 2937 2941 2 2941 2941
total 3944 3876 4019 58 4008 4019
Onboarding New Wallet createWalletToSocialScreen 229 226 232 2 231 232
srpButtonToPwForm 134 132 137 2 137 137
createPwToRecoveryScreen 11 10 12 1 11 12
skipBackupToMetricsScreen 45 43 47 2 47 47
agreeButtonToOnboardingSuccess 24 20 31 4 25 31
doneButtonToAssetList 550 531 566 13 553 566
total 997 974 1013 14 1005 1013
Asset Details assetClickToPriceChart 65 51 85 13 76 85
total 65 51 85 13 76 85
Solana Asset Details assetClickToPriceChart 158 99 196 43 195 196
total 158 99 196 43 195 196
Import Srp Home loginToHomeScreen 2312 2228 2395 56 2336 2395
openAccountMenuAfterLogin 59 58 61 1 61 61
homeAfterImportWithNewWallet 2252 2201 2302 38 2269 2302
total 4604 4555 4684 52 4618 4684
Send Transactions openSendPageFromHome 29 25 34 3 30 34
selectTokenToSendFormLoaded 38 28 46 7 45 46
reviewTransactionToConfirmationPage 1273 868 1591 312 1583 1591
total 1348 923 1698 329 1670 1698
Swap openSwapPageFromHome 127 112 137 10 134 137
fetchAndDisplaySwapQuotes 2697 2686 2710 10 2707 2710
total 2822 2820 2825 2 2825 2825

🌐 Dapp Page Load Benchmarks

Current Commit: 6d556cc | Date: 3/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±43ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±63ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 92ms (±129ms) 🟢 | historical mean value: 83ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	43ms	1.02s	1.37s	1.07s	1.37s
domContentLoaded	740ms	63ms	711ms	1.31s	752ms	1.31s
firstPaint	92ms	129ms	64ms	1.38s	88ms	1.38s
firstContentfulPaint	92ms	129ms	64ms	1.38s	88ms	1.38s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

Test the INS_NOT_SUPPORTED fallback path in signTypedData that falls back to signEIP712HashedMessage when clear signing is unsupported.

metamaskbotv2 · 2026-03-19T09:44:31Z

Builds ready [6f4cd8c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 278 261 292 13 291 292
total 278 261 292 13 291 292
Confirm Tx confirm_tx 6025 6018 6031 5 6026 6031
total 6025 6018 6031 5 6026 6031
Bridge User Actions bridge_load_page 262 252 275 9 266 275
bridge_load_asset_picker 171 154 189 13 174 189
bridge_search_token 710 696 730 15 726 730
total 1129 1096 1156 24 1146 1156

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1461 1271 1809 103 1484 1676
load 1208 1032 1604 96 1232 1387
domContentLoaded 1200 1023 1579 93 1228 1377
domInteractive 30 18 114 22 26 87
firstPaint 158 66 431 82 213 311
backgroundConnect 217 198 424 25 216 247
firstReactRender 19 13 38 4 21 25
initialActions 1 0 4 1 2 3
loadScripts 999 831 1362 92 1025 1170
setupStore 14 6 37 5 16 22
numNetworkReqs 39 31 86 15 40 76
Power User Home uiStartup 5670 2345 14994 2153 6790 8597
load 1311 1115 1839 142 1343 1669
domContentLoaded 1292 1110 1799 130 1315 1581
domInteractive 44 20 271 48 35 168
firstPaint 247 89 1603 197 304 409
backgroundConnect 2368 330 10518 1831 3390 5274
firstReactRender 26 17 50 6 28 39
initialActions 1 0 5 1 1 3
loadScripts 1067 903 1481 118 1090 1352
setupStore 17 6 57 9 19 35
numNetworkReqs 143 56 321 38 153 213

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 216 224 3 221 224
srpButtonToSrpForm 93 92 94 1 93 94
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 624 583 657 33 652 657
openAccountMenuToAccountListLoaded 3038 2900 3155 100 3101 3155
total 4029 3849 4180 134 4116 4180
Onboarding New Wallet createWalletToSocialScreen 220 219 220 0 220 220
srpButtonToPwForm 108 107 108 0 108 108
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 40 37 44 2 42 44
agreeButtonToOnboardingSuccess 16 16 16 0 16 16
doneButtonToAssetList 497 479 517 14 504 517
total 882 872 895 9 885 895
Asset Details assetClickToPriceChart 66 46 87 16 76 87
total 66 46 87 16 76 87
Solana Asset Details assetClickToPriceChart 81 80 82 1 82 82
total 81 80 82 1 82 82
Import Srp Home loginToHomeScreen 2378 2337 2426 32 2377 2426
openAccountMenuAfterLogin 63 34 87 21 78 87
homeAfterImportWithNewWallet 1591 507 2332 864 2298 2332
total 4065 2957 4755 830 4746 4755
Send Transactions openSendPageFromHome 27 26 27 0 27 27
selectTokenToSendFormLoaded 34 33 35 1 35 35
reviewTransactionToConfirmationPage 913 893 928 15 928 928
total 943 814 1036 81 979 1036
Swap openSwapPageFromHome 132 117 151 14 140 151
fetchAndDisplaySwapQuotes 2706 2690 2725 12 2712 2725
total 2828 2807 2848 15 2841 2848

🌐 Dapp Page Load Benchmarks

Current Commit: 6f4cd8c | Date: 3/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 734ms (±37ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 81ms (±13ms) 🟢 | historical mean value: 86ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.02s	1.34s	1.06s	1.34s
domContentLoaded	734ms	37ms	711ms	1.02s	749ms	1.02s
firstPaint	81ms	13ms	64ms	196ms	84ms	196ms
firstContentfulPaint	81ms	13ms	64ms	196ms	84ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

montelaidev

LGTM code wise. I can't test because i don't have a nano

ccharly

LGTM (not tested)

sonarqubecloud · 2026-03-19T10:08:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-19T10:31:42Z

Builds ready [10515dd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 270 260 281 9 278 281
total 270 260 281 9 278 281
Confirm Tx confirm_tx 6016 6005 6033 11 6025 6033
total 6016 6005 6033 11 6025 6033
Bridge User Actions bridge_load_page 270 208 321 45 306 321
bridge_load_asset_picker 217 177 259 30 224 259
bridge_search_token 748 735 766 11 746 766
total 1260 1243 1287 17 1260 1287

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1424 1195 1689 104 1470 1614
load 1182 974 1420 92 1226 1331
domContentLoaded 1177 969 1411 92 1222 1326
domInteractive 29 16 118 22 24 88
firstPaint 146 69 396 77 201 291
backgroundConnect 212 195 254 11 219 233
firstReactRender 20 13 47 6 21 32
initialActions 1 0 8 2 1 5
loadScripts 978 775 1200 89 1019 1126
setupStore 14 6 50 7 17 26
numNetworkReqs 39 31 85 16 37 77
Power User Home uiStartup 5736 2089 18036 3165 6649 10808
load 1300 1159 1683 124 1320 1619
domContentLoaded 1282 1143 1656 116 1300 1562
domInteractive 37 21 190 33 34 99
firstPaint 237 87 1575 193 287 409
backgroundConnect 2208 308 14566 2746 2534 6260
firstReactRender 25 16 54 6 28 36
initialActions 1 0 5 1 1 2
loadScripts 1058 936 1402 104 1083 1312
setupStore 17 7 128 14 17 42
numNetworkReqs 240 48 534 88 303 347

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 219 218 219 0 219 219
srpButtonToSrpForm 95 93 95 1 95 95
confirmSrpToPwForm 22 21 23 1 23 23
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 15 15 16 0 16 16
doneButtonToHomeScreen 747 585 1049 177 845 1049
openAccountMenuToAccountListLoaded 2796 2496 2929 171 2927 2929
total 3899 3881 3927 19 3905 3927
Onboarding New Wallet createWalletToSocialScreen 218 217 220 1 219 220
srpButtonToPwForm 105 103 107 1 106 107
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 37 36 38 1 37 38
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 669 465 946 181 748 946
total 1053 848 1328 181 1132 1328
Asset Details assetClickToPriceChart 78 54 104 16 86 104
total 78 54 104 16 86 104
Solana Asset Details assetClickToPriceChart 115 44 178 49 158 178
total 115 44 178 49 158 178
Import Srp Home loginToHomeScreen 2320 2292 2335 20 2335 2335
openAccountMenuAfterLogin 50 33 66 13 61 66
homeAfterImportWithNewWallet 2356 2242 2515 103 2376 2515
total 4728 4628 4820 68 4737 4820
Send Transactions openSendPageFromHome 46 23 61 15 57 61
selectTokenToSendFormLoaded 36 28 42 6 41 42
reviewTransactionToConfirmationPage 1252 716 1648 317 1450 1648
total 1334 812 1751 320 1536 1751
Swap openSwapPageFromHome 124 113 130 8 130 130
fetchAndDisplaySwapQuotes 2691 2688 2695 3 2693 2695
total 2824 2803 2852 18 2824 2852

🌐 Dapp Page Load Benchmarks

Current Commit: 10515dd | Date: 3/19/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±41ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 757ms (±62ms) 🟢 | historical mean value: 721ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 96ms (±130ms) 🟢 | historical mean value: 84ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	41ms	1.04s	1.39s	1.10s	1.39s
domContentLoaded	757ms	62ms	729ms	1.32s	781ms	1.32s
firstPaint	96ms	130ms	68ms	1.39s	92ms	1.39s
firstContentfulPaint	96ms	130ms	68ms	1.39s	92ms	1.39s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

seaona · 2026-03-19T11:56:41Z

Test Dapp Sign Typed V4 and Permit

ledger-nano-s.mov

Uniswap signatures

nano-s-uniswap.mov

gantunesr

lgtm and tested with Nano Gen5

danroc temporarily deployed to pr-comment March 18, 2026 16:04 — with GitHub Actions Inactive

metamaskbot added the team-accounts-framework Accounts team label Mar 18, 2026

github-actions bot added the size-M label Mar 18, 2026

danroc added the hardware-ledger label Mar 18, 2026

danroc temporarily deployed to pr-comment March 18, 2026 16:37 — with GitHub Actions Inactive

danroc marked this pull request as ready for review March 18, 2026 16:48

danroc temporarily deployed to pr-comment March 18, 2026 16:48 — with GitHub Actions Inactive

Merge branch 'main' into dr/fix-blind-sign

0f8ef3d

danroc had a problem deploying to pr-comment March 19, 2026 09:08 — with GitHub Actions Error

test: add signTypedData fallback tests for Nano S

6f4cd8c

Test the INS_NOT_SUPPORTED fallback path in signTypedData that falls back to signEIP712HashedMessage when clear signing is unsupported.

danroc temporarily deployed to pr-comment March 19, 2026 09:09 — with GitHub Actions Inactive

danroc temporarily deployed to pr-comment March 19, 2026 09:39 — with GitHub Actions Inactive

chore: undo linter fix

10515dd

danroc temporarily deployed to pr-comment March 19, 2026 09:54 — with GitHub Actions Inactive

montelaidev approved these changes Mar 19, 2026

View reviewed changes

ccharly approved these changes Mar 19, 2026

View reviewed changes

danroc temporarily deployed to pr-comment March 19, 2026 10:27 — with GitHub Actions Inactive

gantunesr approved these changes Mar 19, 2026

View reviewed changes

gantunesr added this pull request to the merge queue Mar 19, 2026

Merged via the queue into main with commit 1173008 Mar 19, 2026
206 checks passed

gantunesr deleted the dr/fix-blind-sign branch March 19, 2026 13:17

github-actions bot locked and limited conversation to collaborators Mar 19, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fall back to blind signing when clear signing not supported by Ledger device#41017

fix: fall back to blind signing when clear signing not supported by Ledger device#41017
gantunesr merged 4 commits intomainfrom
dr/fix-blind-sign

danroc commented Mar 18, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

montelaidev left a comment

Uh oh!

ccharly left a comment

Uh oh!

sonarqubecloud bot commented Mar 19, 2026

Uh oh!

metamaskbotv2 bot commented Mar 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

seaona commented Mar 19, 2026

Uh oh!

gantunesr left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

danroc commented Mar 18, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbotv2 bot commented Mar 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

montelaidev left a comment

Choose a reason for hiding this comment

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 19, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 19, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

seaona commented Mar 19, 2026

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

danroc commented Mar 18, 2026 •

edited by cursor bot

Loading