Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (1 files, +26 -1)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Builds ready [a0072a4]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
Contributor
Builds ready [9dff676]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
micaelae
approved these changes
Mar 18, 2026
SteP-n-s
approved these changes
Mar 18, 2026
Contributor
SteP-n-s
left a comment
There was a problem hiding this comment.
Non‑blocking comment: is the serialize function specifically implemented for bridge needs, or can it be used in other parts of the app as well? Looking at the logic, it seems more like a generic utility rather than something bound to the Swaps feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mitigate an issue where state passed via useNavigate is not serialized correctly.
For a better long-term design, prefer to retrieve data from the receiving page.
Changelog
CHANGELOG entry: fix: swap activity history details
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
swap-detail.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk UI navigation change that only affects how transaction data is passed via
useNavigate, reducing failures caused by non-serializable values likebigint. Potential risk is minor: downstream consumers may now receive stringified bigint fields instead of nativebigint.Overview
Fixes swap/bridge activity details navigation by serializing
txMetabefore passing it innavigatestate forCROSS_CHAIN_SWAP_TX_DETAILS_ROUTE.Adds a recursive
serializehelper that convertsbigintvalues to strings (and walks arrays/objects) to avoid non-serializable history state being pushed through React Router; includes a TODO to eventually fetch details on the destination route instead.Written by Cursor Bugbot for commit 9dff676. This will update automatically on new commits. Configure here.