fix: Adjusted size and padding for sidebar width by Montoya · Pull Request #40988 · MetaMask/metamask-extension

Montoya · 2026-03-17T21:27:21Z

Description

Sidebar is more narrow than popup, causing banner content to get truncated even when the content is within our length limit.

Changelog

CHANGELOG entry: Fixed banner display in sidebar view

Related issues

Fixes: #40978

Manual testing steps

Open extension in sidebar
Observe banner

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable N/A
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk visual-only changes that adjust spacing and typography to fit carousel banner content in the sidebar without affecting behavior or data handling.

Overview
Improves sidebar rendering of the multichain carousel banner by tightening the card layout.

Reduces .carousel-card horizontal padding and inter-element gap, and downgrades title/description TextVariants in StackCard to smaller sizes so content fits within the narrower sidebar width.

^{Written by Cursor Bugbot for commit 4bc051a. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-17T21:27:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-17T21:28:05Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +4 -5)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 carousel/
      - 📁 stack-card/
        
        📄 stack-card.tsx +2 -2
        
        📄 index.scss +2 -3

metamaskbotv2 · 2026-03-17T22:02:58Z

Builds ready [f96a746]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 367 271 499 105 492 499
total 367 271 499 105 492 499
Confirm Tx confirm_tx 5984 5956 6015 21 5983 6015
total 5984 5956 6015 21 5983 6015
Bridge User Actions bridge_load_page 207 193 228 15 223 228
bridge_load_asset_picker 255 244 269 9 259 269
bridge_search_token 758 748 770 8 761 770
total 1220 1192 1246 18 1232 1246

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1439 1224 2037 121 1469 1635
load 1191 997 1725 107 1220 1358
domContentLoaded 1184 993 1691 104 1212 1345
domInteractive 29 15 160 23 25 88
firstPaint 138 66 466 80 191 261
backgroundConnect 210 194 286 14 210 245
firstReactRender 20 12 46 6 22 32
initialActions 1 0 10 2 2 5
loadScripts 988 794 1484 101 1023 1149
setupStore 14 7 32 6 17 29
numNetworkReqs 39 31 81 15 34 79
Power User Home uiStartup 5429 2259 17596 2565 6342 8273
load 1322 1132 3387 249 1343 1614
domContentLoaded 1300 1121 3381 245 1307 1588
domInteractive 37 19 266 37 31 95
firstPaint 203 80 533 91 273 340
backgroundConnect 2287 304 14480 2363 3576 4940
firstReactRender 24 17 40 5 26 33
initialActions 1 0 4 1 1 2
loadScripts 1078 916 3148 240 1082 1340
setupStore 19 7 311 30 18 31
numNetworkReqs 145 69 282 36 153 239

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 217 223 2 222 223
srpButtonToSrpForm 93 86 97 4 97 97
confirmSrpToPwForm 23 22 25 1 22 25
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 15 17 1 16 17
doneButtonToHomeScreen 603 580 636 20 603 636
openAccountMenuToAccountListLoaded 2918 2894 2941 17 2919 2941
total 3890 3887 3895 4 3895 3895
Onboarding New Wallet createWalletToSocialScreen 220 219 221 1 220 221
srpButtonToPwForm 111 108 114 2 112 114
createPwToRecoveryScreen 9 8 9 0 9 9
skipBackupToMetricsScreen 41 39 43 1 42 43
agreeButtonToOnboardingSuccess 17 16 17 0 17 17
doneButtonToAssetList 537 310 679 133 656 679
total 934 705 1078 134 1054 1078
Asset Details assetClickToPriceChart 80 71 85 5 84 85
total 80 71 85 5 84 85
Solana Asset Details assetClickToPriceChart 68 40 127 34 85 127
total 68 40 127 34 85 127
Import Srp Home loginToHomeScreen 2328 2298 2360 25 2360 2360
openAccountMenuAfterLogin 62 43 75 13 74 75
homeAfterImportWithNewWallet 1492 603 2399 827 2232 2399
total 4059 3088 4800 697 4635 4800
Send Transactions openSendPageFromHome 23 17 29 5 26 29
selectTokenToSendFormLoaded 29 24 35 4 33 35
reviewTransactionToConfirmationPage 1289 938 1527 247 1512 1527
total 1349 995 1594 249 1583 1594
Swap openSwapPageFromHome 138 137 139 1 139 139
fetchAndDisplaySwapQuotes 2701 2683 2726 15 2706 2726
total 2832 2793 2865 24 2843 2865

🌐 Dapp Page Load Benchmarks

Current Commit: f96a746 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 726ms (±38ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 88ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.01s	1.33s	1.06s	1.33s
domContentLoaded	726ms	38ms	703ms	1.01s	752ms	1.01s
firstPaint	79ms	10ms	64ms	152ms	88ms	152ms
firstContentfulPaint	79ms	10ms	64ms	152ms	88ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

sonarqubecloud · 2026-03-18T03:44:37Z

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

metamaskbotv2 · 2026-03-18T04:09:40Z

Builds ready [4bc051a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 303 274 351 28 318 351
total 303 274 351 28 318 351
Confirm Tx confirm_tx 6028 6017 6036 7 6031 6036
total 6028 6017 6036 7 6031 6036
Bridge User Actions bridge_load_page 245 217 267 19 257 267
bridge_load_asset_picker 163 150 188 15 157 188
bridge_search_token 709 696 728 12 707 728
total 1117 1093 1151 21 1112 1151

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1450 1227 1986 111 1496 1618
load 1201 1008 1717 100 1240 1359
domContentLoaded 1194 1001 1670 98 1235 1352
domInteractive 29 15 124 20 25 82
firstPaint 162 66 1685 171 207 292
backgroundConnect 215 195 250 11 221 237
firstReactRender 20 14 52 6 20 33
initialActions 1 0 5 1 2 4
loadScripts 994 806 1463 96 1029 1140
setupStore 12 7 28 5 15 21
numNetworkReqs 39 31 84 16 40 79
Power User Home uiStartup 5497 2324 15450 2280 6391 8750
load 1340 1177 1856 134 1364 1656
domContentLoaded 1319 1170 1836 132 1343 1638
domInteractive 40 19 236 37 35 129
firstPaint 215 86 525 92 288 352
backgroundConnect 1867 356 11768 2130 2914 5112
firstReactRender 25 17 56 6 26 30
initialActions 1 0 4 1 1 3
loadScripts 1089 945 1548 124 1104 1383
setupStore 16 6 46 7 19 31
numNetworkReqs 210 114 340 52 227 318

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 218 224 2 222 224
srpButtonToSrpForm 92 88 96 3 93 96
confirmSrpToPwForm 22 21 22 0 22 22
pwFormToMetricsScreen 15 15 15 0 15 15
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 618 601 638 13 616 638
openAccountMenuToAccountListLoaded 2918 2898 2940 16 2933 2940
total 3902 3881 3923 16 3910 3923
Onboarding New Wallet createWalletToSocialScreen 223 222 223 0 223 223
srpButtonToPwForm 114 114 114 0 114 114
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 42 39 44 2 43 44
agreeButtonToOnboardingSuccess 17 17 17 0 17 17
doneButtonToAssetList 532 514 545 10 538 545
total 935 916 950 12 944 950
Asset Details assetClickToPriceChart 64 45 108 24 74 108
total 64 45 108 24 74 108
Solana Asset Details assetClickToPriceChart 95 43 147 41 123 147
total 95 43 147 41 123 147
Import Srp Home loginToHomeScreen 2335 2180 2496 103 2380 2496
openAccountMenuAfterLogin 71 67 76 3 72 76
homeAfterImportWithNewWallet 1663 632 2376 782 2307 2376
total 4073 3088 4669 702 4630 4669
Send Transactions openSendPageFromHome 29 24 33 4 32 33
selectTokenToSendFormLoaded 34 25 40 6 37 40
reviewTransactionToConfirmationPage 1102 875 1446 243 1342 1446
total 1170 936 1509 238 1404 1509
Swap openSwapPageFromHome 91 32 141 39 125 141
fetchAndDisplaySwapQuotes 2702 2687 2714 10 2708 2714
total 2781 2731 2812 31 2803 2812

🌐 Dapp Page Load Benchmarks

Current Commit: 4bc051a | Date: 3/18/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±50ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 735ms (±63ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 93ms (±131ms) 🟢 | historical mean value: 87ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	50ms	1.02s	1.47s	1.07s	1.47s
domContentLoaded	735ms	63ms	712ms	1.31s	748ms	1.31s
firstPaint	93ms	131ms	64ms	1.40s	96ms	1.40s
firstContentfulPaint	93ms	131ms	64ms	1.40s	96ms	1.40s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 13.9 KiB (0.12%)

Adjusted size and padding for sidebar width

f96a746

Montoya requested a review from a team as a code owner March 17, 2026 21:27

Montoya added the team-engagement label Mar 17, 2026

Montoya temporarily deployed to pr-comment March 17, 2026 21:27 — with GitHub Actions Inactive

metamaskbot added the team-rewards Rewards team label Mar 17, 2026

github-actions bot added the size-XS label Mar 17, 2026

Montoya temporarily deployed to pr-comment March 17, 2026 21:58 — with GitHub Actions Inactive

Additional changes

4bc051a

Montoya temporarily deployed to pr-comment March 18, 2026 03:31 — with GitHub Actions Inactive

Montoya temporarily deployed to pr-comment March 18, 2026 04:04 — with GitHub Actions Inactive

ameliejyc approved these changes Mar 18, 2026

View reviewed changes

Montoya enabled auto-merge March 18, 2026 19:35

jbblanc approved these changes Mar 19, 2026

View reviewed changes

Montoya added this pull request to the merge queue Mar 19, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2026

Montoya added this pull request to the merge queue Mar 19, 2026

Merged via the queue into main with commit dce13ca Mar 19, 2026
190 of 191 checks passed

Montoya deleted the GE-154-adjust-sidebar-banners branch March 19, 2026 15:51

github-actions bot locked and limited conversation to collaborators Mar 19, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Adjusted size and padding for sidebar width#40988

fix: Adjusted size and padding for sidebar width#40988
Montoya merged 2 commits intomainfrom
GE-154-adjust-sidebar-banners

Montoya commented Mar 17, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 18, 2026

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Montoya commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud bot commented Mar 18, 2026

Quality Gate failed

Uh oh!

metamaskbotv2 bot commented Mar 18, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Montoya commented Mar 17, 2026 •

edited

Loading

metamaskbotv2 bot commented Mar 17, 2026 •

edited

Loading