fix: (import-tokens) validate duplicate token checks by selected network by Prithpal-Sooriya · Pull Request #40969 · MetaMask/metamask-extension

Prithpal-Sooriya · 2026-03-17T15:17:03Z

Description

Fixes a false "Token has already been added" validation in the multichain import token modal.

The duplicate-token check was reading tokens from the home network selector (chainId) instead of the network currently selected inside the import modal (selectedNetwork). This caused cross-network false positives when users imported the same token address on another chain.

This change keeps scope minimal:

Use selectedNetwork for duplicate address validation
Add a regression test that reproduces the mismatch scenario and asserts that tokenAlreadyAdded is not shown

Changelog

CHANGELOG entry: fix: (import-tokens) validate duplicate token checks by selected network

Related issues

Fixes: #38954 https://consensyssoftware.atlassian.net/browse/ASSETS-2177

Manual testing steps

Open Import tokens modal.
Ensure a token is already imported on network A.
In the import modal, switch to network B and input the same token address.
Verify "Token has already been added" is not shown for network B.

Screenshots/Recordings

Before

After

https://www.loom.com/share/dce5af505797496da9532d936b6e4715

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

github-actions · 2026-03-17T15:17:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-17T15:17:52Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (2 files, +35 -1)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 import-tokens-modal/
      - 📄 import-tokens-modal.js +1 -1
      - 📄 import-tokens-modal.test.js +34 -0

sonarqubecloud · 2026-03-17T15:30:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-03-17T15:55:01Z

Builds ready [9b582e1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 283 273 295 8 283 295
total 283 273 295 8 283 295
Confirm Tx confirm_tx 6011 6000 6027 12 6024 6027
total 6011 6000 6027 12 6024 6027
Bridge User Actions bridge_load_page 209 208 209 0 209 209
bridge_load_asset_picker 215 140 256 47 251 256
bridge_search_token 764 746 778 13 778 778
total 1224 1205 1234 14 1234 1234

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Standard Home uiStartup 1497 1246 1937 105 1541 1675
load 1244 1036 1625 104 1287 1437
domContentLoaded 1237 1030 1597 102 1281 1427
domInteractive 31 18 116 22 26 87
firstPaint 153 73 392 75 212 289
backgroundConnect 222 202 265 12 227 245
firstReactRender 20 13 45 4 20 27
initialActions 1 0 7 1 2 4
loadScripts 1031 841 1391 99 1072 1223
setupStore 13 7 37 5 17 22
numNetworkReqs 39 31 81 15 40 77
Power User Home uiStartup 6344 2143 15907 2804 6784 13448
load 1334 1172 1924 132 1358 1621
domContentLoaded 1314 1165 1909 127 1338 1583
domInteractive 39 22 221 31 35 100
firstPaint 221 86 624 101 292 378
backgroundConnect 2529 323 14077 2877 3387 10601
firstReactRender 25 16 39 4 27 33
initialActions 1 0 8 1 2 4
loadScripts 1084 941 1655 118 1109 1316
setupStore 16 7 52 8 19 32
numNetworkReqs 191 87 373 57 213 319

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 220 217 222 2 221 222
srpButtonToSrpForm 96 93 98 2 98 98
confirmSrpToPwForm 22 22 23 0 22 23
pwFormToMetricsScreen 15 15 16 0 16 16
metricsToWalletReadyScreen 16 16 16 0 16 16
doneButtonToHomeScreen 637 587 679 33 645 679
openAccountMenuToAccountListLoaded 2909 2908 2911 1 2908 2911
total 3915 3866 3954 32 3928 3954
Onboarding New Wallet createWalletToSocialScreen 220 219 221 1 220 221
srpButtonToPwForm 115 114 116 1 115 116
createPwToRecoveryScreen 9 9 9 0 9 9
skipBackupToMetricsScreen 41 40 43 1 42 43
agreeButtonToOnboardingSuccess 18 17 18 0 18 18
doneButtonToAssetList 558 489 688 78 608 688
total 961 892 1094 79 1012 1094
Asset Details assetClickToPriceChart 69 49 85 13 76 85
total 69 49 85 13 76 85
Solana Asset Details assetClickToPriceChart 43 34 53 8 50 53
total 43 34 53 8 50 53
Import Srp Home loginToHomeScreen 2296 2260 2335 28 2322 2335
openAccountMenuAfterLogin 76 69 87 7 79 87
homeAfterImportWithNewWallet 1611 535 2421 877 2330 2421
total 3975 2873 4734 868 4683 4734
Send Transactions openSendPageFromHome 23 14 30 6 28 30
selectTokenToSendFormLoaded 32 18 43 9 38 43
reviewTransactionToConfirmationPage 867 696 1008 113 904 1008
total 1043 809 1403 206 1120 1403
Swap openSwapPageFromHome 92 90 93 1 93 93
fetchAndDisplaySwapQuotes 2685 2682 2688 2 2686 2688
total 2775 2772 2779 3 2779 2779

🌐 Dapp Page Load Benchmarks

Current Commit: 9b582e1 | Date: 3/17/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±63ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 83ms (±43ms) 🟢 | historical mean value: 87ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	42ms	1.03s	1.37s	1.06s	1.37s
domContentLoaded	740ms	63ms	718ms	1.32s	751ms	1.32s
firstPaint	83ms	43ms	64ms	512ms	92ms	512ms
firstContentfulPaint	83ms	43ms	64ms	512ms	92ms	512ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 58 Bytes (0%)
ui: 5 Bytes (0%)
common: 20 Bytes (0%)

ui/components/multichain/import-tokens-modal/import-tokens-modal.js

fix(import-tokens): validate duplicates on selected network

9b582e1

Co-authored-by: Prithpal Sooriya <prithpal.sooriya@gmail.com>

Prithpal-Sooriya temporarily deployed to pr-comment March 17, 2026 15:17 — with GitHub Actions Inactive

metamaskbot added the team-assets label Mar 17, 2026

cursor bot mentioned this pull request Mar 17, 2026

[Bug]: Can't import multi-chain tokens (Printr) #38954

Closed

github-actions bot added the size-S label Mar 17, 2026

Prithpal-Sooriya changed the title ~~fix(import-tokens): validate duplicate token checks by selected network~~ fix: (import-tokens) validate duplicate token checks by selected network Mar 17, 2026

Prithpal-Sooriya marked this pull request as ready for review March 17, 2026 15:29

Prithpal-Sooriya requested a review from a team as a code owner March 17, 2026 15:29

Prithpal-Sooriya temporarily deployed to pr-comment March 17, 2026 15:29 — with GitHub Actions Inactive

Prithpal-Sooriya temporarily deployed to pr-comment March 17, 2026 15:50 — with GitHub Actions Inactive

bergarces approved these changes Mar 17, 2026

View reviewed changes

Prithpal-Sooriya enabled auto-merge March 17, 2026 16:44

Prithpal-Sooriya commented Mar 17, 2026

View reviewed changes

ui/components/multichain/import-tokens-modal/import-tokens-modal.js Show resolved Hide resolved

NidhiKJha approved these changes Mar 17, 2026

View reviewed changes

Prithpal-Sooriya added this pull request to the merge queue Mar 17, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 17, 2026

Prithpal-Sooriya added this pull request to the merge queue Mar 17, 2026

Merged via the queue into main with commit fa75613 Mar 17, 2026
204 of 205 checks passed

Prithpal-Sooriya deleted the cursor/multi-chain-token-import-validation-72be branch March 17, 2026 18:29

github-actions bot locked and limited conversation to collaborators Mar 17, 2026

metamaskbot added the release-13.24.0 Issue or pull request that will be included in release 13.24.0 label Mar 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: (import-tokens) validate duplicate token checks by selected network#40969

fix: (import-tokens) validate duplicate token checks by selected network#40969
Prithpal-Sooriya merged 1 commit intomainfrom
cursor/multi-chain-token-import-validation-72be

Prithpal-Sooriya commented Mar 17, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Prithpal-Sooriya commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

sonarqubecloud bot commented Mar 17, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Mar 17, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Prithpal-Sooriya commented Mar 17, 2026 •

edited

Loading