Conversation
…unify-state selectors When assets-unify-state is enabled, assetsInfo stores native EVM tokens using slip44:60 (EVM generic coin type) while assetsPrice may use a chain-specific slip44 (e.g. slip44:9005 for AVAX on Avalanche C-Chain). This mismatch caused two selectors to silently skip affected native tokens: - getCurrencyRateControllerCurrencyRates: no conversion rate for AVAX, making token.secondary undefined on the token list - getTokenRatesControllerMarketData: no market data for AVAX, making pricePercentChange1d undefined and hiding the % change badge Both selectors now fall back to a chain-prefix scan when the direct assetId lookup misses, bridging the key mismatch without changing stored state.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [6997581]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
Contributor
Builds ready [ef0e39e]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergarces
reviewed
Mar 17, 2026
| continue; | ||
| } | ||
|
|
||
| // assetsInfo may use slip44:60 (EVM standard) for native tokens while assetsPrice |
Contributor
There was a problem hiding this comment.
Is there something we can do in the future to stop assetsInfo having the wrong assetId?
Contributor
Author
There was a problem hiding this comment.
we can hardcode a list but this is not the best approach
bergarces
approved these changes
Mar 17, 2026
Prithpal-Sooriya
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When assets-unify-state is enabled, assetsInfo stores native EVM tokens using slip44:60 (EVM generic coin type) while assetsPrice may use a chain-specific slip44 (e.g. slip44:9005 for AVAX on Avalanche C-Chain).
This mismatch caused two selectors to silently skip affected native tokens:
Both selectors now fall back to a chain-prefix scan when the direct assetId lookup misses, bridging the key mismatch without changing stored state.
Changelog
CHANGELOG entry: resolve slip44 key mismatch for native tokens in assets-unify-state selectors
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches rate/market-data selectors used for token pricing and currency conversion; the new chain-prefix fallback could select an unintended slip44 entry if multiple native-price keys exist for a chain.
Overview
Fixes assets-unify-state selectors to handle native EVM tokens when
assetsInfousesslip44:60butassetsPriceuses a chain-specificslip44(e.g. AVAX).getCurrencyRateControllerCurrencyRatesnow falls back to any nativeslip44:*price entry for the same chain when a direct lookup misses.Similarly,
getTokenRatesControllerMarketDataadds a guarded fallback (only for nativeslip44assets) to find matching native metadata inassetsInfo, preventing misattribution of ERC-20 prices.Expands
assets-migration.test.tswith many new edge-case tests across the migrated selectors (dedupingcustomAssets, skipping missing metadata/non-EVM assets, multi-account/multi-chain behavior, decimal parsing), including explicit coverage for the slip44 mismatch scenarios.Written by Cursor Bugbot for commit ef0e39e. This will update automatically on new commits. Configure here.